Skip to content

Commit ecf899a

Browse files
authored
Fix ignore parameters in dbpedia and msmarco-passage-ranking (#761)
The `size` and `track_total_hits` params are ignored in the dbpedia and msmarco-passage-ranking tracks. This change fixes the issue by providing the params as part of the search request body.
1 parent ef11d3e commit ecf899a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

msmarco-passage-ranking/track.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,11 @@ def params(self):
165165
raise Exception(f"The query strategy \\`{self._query_strategy}]\\` is not implemented")
166166

167167
self._iters = (self._iters + 1) % len(self._queries)
168+
query["track_total_hits"] = self._track_total_hits
169+
query["size"] = self._size
168170
return {
169171
"index": self._index_name,
170172
"cache": self._cache,
171-
"size": self._size,
172-
"track_total_hits": self._track_total_hits,
173173
"body": query,
174174
}
175175

search/mteb/dbpedia/track.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,13 @@ def partition(self, partition_index, total_partitions):
103103
def params(self):
104104
query_obj = self._queries[self._iters]
105105
query = generate_query(query_obj["text"], self._title_field, self._title_boost, self._text_field, self._text_boost)
106+
query["track_total_hits"] = self._track_total_hits
107+
query["size"] = self._size
106108

107109
self._iters = (self._iters + 1) % len(self._queries)
108110
return {
109111
"index": self._index_name,
110112
"cache": self._cache,
111-
"size": self._size,
112-
"track_total_hits": self._track_total_hits,
113113
"body": query,
114114
}
115115

0 commit comments

Comments
 (0)