[Azure] [OpenAI] Update metric types from gauge to counter #9944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits May 22, 2024 22:33
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @lucian-ioan |
|
| Package azure_openai - 0.0.2 containing this change is available at https://epr.elastic.co/search?package=azure_openai |
4 tasks
andrewkroh added Integration:azure_openai Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Update metric types from gauge to counter for Azure OpenAI integration.
The metric type "gauge" is used for values that can go up or down such as memory usage or current active requests. It represents the current value at a specific point in time.
For metrics that represent cumulative counts, such as the total number of requests or tokens over time, the "counter" metric type is more appropriate. Counters only increase (or reset), making them suitable for cumulative data.
Changes to metric types:
provisioned_managed_utilization_v2.avg-> kept as gauge, since it represents a percentage that can vary.active_tokens.total-> kept as gauge, (total tokens - cached tokens) over a period of time, this can decrease if the number of cached tokens increases.Rest of the fields are updated to
metric_type: counterChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots