cisco_meraki: improve event handling #9841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
efd6 added enhancement 
* anyconnect_vpn_auth_success * anyconnect_vpn_connect * anyconnect_vpn_disconnect * anyconnect_vpn_session_manager * martian_vlan * splash_auth
🚀 Benchmarks reportTo see the full report comment with |
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
andrewkroh approved these changes May 17, 2024
Member
andrewkroh left a comment
andrewkroh left a comment There was a problem hiding this comment.
Other than the questions, LGTM
| NOTCOLON: '[^:]*' | ||
| REASON: ' Reason: %{DATA:cisco_meraki.anyconnect_vpn_session_manager.reason}' | ||
| if: ctx.cisco_meraki?.event_subtype == "anyconnect_vpn_session_manager" | ||
| # ignore_failure: true |
Member
There was a problem hiding this comment.
Do you want ignore_failure turned on here?
Contributor Author
There was a problem hiding this comment.
Yeah, I do. I was turning it off to find issues.
| TUNNEL: '%{WORD:cisco_meraki.anyconnect_vpn_session_manager.tunnel_type} tunnel\[%{NOTBRACKET:cisco_meraki.anyconnect_vpn_session_manager.tunnel_id}\]' | ||
| NOTBRACKET: '[^\]]*' | ||
| if: ctx._temp?.right != null | ||
| # ignore_failure: true |
💚 Build Succeeded
History
cc @efd6 |
|
| Package cisco_meraki - 1.22.0 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots