Skip to content

slack: map md5 hash detail for files #9417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2024
Merged

slack: map md5 hash detail for files #9417

merged 2 commits into from
Mar 25, 2024

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Mar 22, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added enhancement New feature or request Integration:slack Slack Logs (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Mar 22, 2024
@efd6 efd6 self-assigned this Mar 22, 2024
@elasticmachine
Copy link

elasticmachine commented Mar 22, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@efd6 efd6 marked this pull request as ready for review March 22, 2024 05:05
@efd6 efd6 requested a review from a team as a code owner March 22, 2024 05:05
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@efd6 efd6 requested a review from aarju March 22, 2024 05:05
kcreddy
kcreddy approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
packages/slack/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Comment on lines +147 to +151
- set:
field: file.hash.md5
copy_from: slack.audit.details.md5
ignore_empty_value: true
if: ctx.slack?.audit?.entity?.entity_type == "file"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we copy this into related.hash as well?
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube
@efd6 efd6 merged commit 64ac5cc into elastic:main Mar 25, 2024
@elasticmachine
Copy link

Package slack - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=slack
@efd6 efd6 deleted the 9353-slack branch February 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:slack Slack Logs (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants

@efd6 @elasticmachine @kcreddy