Azure Logs: set field type to password on secret fields #9159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `connection_string` and `storage_account_key` have been marked as `secret` in a previous PR, but I did not update the field type as password. AFAIK leaving the type as text does not have side effects, but I I should align the field type with the semantics.
zmoog added bug 
🚀 Benchmarks reportTo see the full report comment with |
gizas approved these changes Feb 15, 2024
💚 Build Succeeded
History
cc @zmoog |
|
| Package azure - 1.9.1 containing this change is available at https://epr.elastic.co/search?package=azure |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Update the field type from
texttopasswordon fields marked assecret.The
connection_stringandstorage_account_keyhave been marked assecretin the previous PR #9022, but I did not update the field type as password.AFAIK, leaving the type as
textdoes not have side effects; however, I want to align the field type with the semantics.Checklist
changelog.ymlfile.Related issues