Skip to content

[NGINX] Add support for tags in stub status metrics #9081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 16, 2024
Merged

[NGINX] Add support for tags in stub status metrics #9081

merged 11 commits into from
Feb 16, 2024

Conversation

@SimonKoetting
Copy link
Contributor

@SimonKoetting SimonKoetting commented Feb 7, 2024

[NGINX] Add support for tags in stub status metrics
@SimonKoetting SimonKoetting requested a review from a team as a code owner February 7, 2024 08:57
@muthu-mps
Copy link
Contributor

muthu-mps commented Feb 7, 2024

/test
1 similar comment
@shmsr
Copy link
Member

shmsr commented Feb 7, 2024

/test
@shmsr shmsr added the enhancement New feature or request label Feb 7, 2024
@SimonKoetting
Copy link
Contributor Author

SimonKoetting commented Feb 7, 2024

/test
@ali786XI
Copy link
Contributor

ali786XI commented Feb 8, 2024 •
edited
Loading

@SimonKoetting As we are supporting the data stream with the tags field, please add it to the ecs.yml like this.

Also, the corresponding /nginx/data_stream/stubstatus/sample_event.json needs to be updated by generating it. You can do this by this command elastic-package test system -v -d stubstatus -g

Also one more thing to do is to build the README.md
@ali786XI ali786XI self-requested a review February 8, 2024 07:11
muthu-mps
muthu-mps reviewed Feb 8, 2024
View reviewed changes
@elasticmachine
Copy link

elasticmachine commented Feb 8, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
ali786XI
ali786XI approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
muthu-mps
muthu-mps approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@elasticmachine
Copy link

elasticmachine commented Feb 13, 2024

💚 Build Succeeded

History

cc @SimonKoetting
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Feb 13, 2024

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube
@lalit-satapathy
Copy link
Contributor

lalit-satapathy commented Feb 16, 2024

Merging for @SimonKoetting.
@lalit-satapathy lalit-satapathy merged commit 6ac25be into elastic:main Feb 16, 2024
@SimonKoetting SimonKoetting deleted the nginx_add_tag branch February 16, 2024 09:23
@elasticmachine
Copy link

elasticmachine commented Feb 16, 2024

Package nginx - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=nginx
gizas pushed a commit that referenced this pull request Mar 13, 2024
@SimonKoetting @gizas
[NGINX] Add support for tags in stub status metrics (#9081)
f3212c0 
* [NGINX] Add support for tags in stub status metrics
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
@SimonKoetting @gizas
[NGINX] Add support for tags in stub status metrics (#9081)
926f7b6 
* [NGINX] Add support for tags in stub status metrics
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@SimonKoetting @gizas
[NGINX] Add support for tags in stub status metrics (#9081)
445abb2 
* [NGINX] Add support for tags in stub status metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:nginx Nginx

6 participants

@SimonKoetting @muthu-mps @shmsr @ali786XI @elasticmachine @lalit-satapathy