apm: add transaction.profiler_stack_trace_ids field to traces datastream mapping #9080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
|
Unrelated package is failed to pass the tests, but I can see it built the apm package successfully: https://buildkite.com/elastic/integrations/builds/8684#018d827b-6911-4deb-83b9-8b82bbc3c160 cc @jsoriano |
🚀 Benchmarks reportPackage |
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
applocker_msi_and_script | 10309.28 | 8000 | -2309.28 (-22.4%) | 💔 |
applocker_packaged_app_execution | 22222.22 | 16949.15 | -5273.07 (-23.73%) | 💔 |
sysmon_operational | 2865.33 | 2398.08 | -467.25 (-16.31%) | 💔 |
To see the full report comment with /test benchmark fullreport
carsonip reviewed Feb 7, 2024
💚 Build Succeeded
History
cc @kyungeunni |
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add
transaction.profiler_stack_trace_ids fieldto traces datastream mappingIt requires the package-spec v3.1.0 which should be shipped with the next release of elastic-package(current release is v0.96.1)
Checklist
changelog.ymlfile.Author's Checklist
elastic-packagewhich includes package version 3.1.0How to test this PR locally
clone the elastic-package, then run:
This will move the binary built from the latest commit to
$GOBIN.Then go to the apm package directory and checkout to this branch, then run:
It shouldn't print any error logs, and look something like this:
Test with Registry
When installed, Go to Kibana, and navigate to
Stack Management > Index Management > Componentand search fortraces. the component should show the added field with the counted_keyword type.Related issues