Skip to content

cisco_secure_email_gateway: handle and record log host origin filepaths #8695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

cisco_secure_email_gateway: handle and record log host origin filepaths #8695

merged 1 commit into from
Dec 12, 2023

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Dec 12, 2023

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 self-assigned this Dec 12, 2023
@efd6 efd6 force-pushed the 8688-cisco_secure_email_gateway branch from 1a3a5e0 to c53a1fc Compare December 12, 2023 02:36
efd6
efd6 commented Dec 12, 2023
View reviewed changes
..._secure_email_gateway/_dev/deploy/docker/sample_logs/authentication.example.com.@123456789.s Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rename tests the change.
@elasticmachine
Copy link

elasticmachine commented Dec 12, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-12T03:19:07.692+0000

  • Duration: 16 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@efd6 efd6 force-pushed the 8688-cisco_secure_email_gateway branch from c53a1fc to 3aeeb23 Compare December 12, 2023 03:18
@elasticmachine
Copy link

🚀 Benchmarks report

Package cisco_secure_email_gateway 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1531.39 1157.41 -373.98 (-24.42%) 💔

To see the full report comment with /test benchmark fullreport
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 84.615% (11/13) 👎 -9.829
Classes 84.615% (11/13) 👎 -9.829
Methods 89.831% (53/59) 👎 -5.138
Lines 89.215% (761/853) 👍 1.509
Conditionals 100.0% (0/0) 💚
@efd6 efd6 marked this pull request as ready for review December 12, 2023 04:43
@efd6 efd6 requested a review from a team as a code owner December 12, 2023 04:43
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
kcreddy
kcreddy approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
System test passed with assert hit count expected 92, observed 92
@efd6 efd6 merged commit bf66d71 into elastic:main Dec 12, 2023
@elasticmachine
Copy link

Package cisco_secure_email_gateway - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=cisco_secure_email_gateway
@efd6 efd6 deleted the 8688-cisco_secure_email_gateway branch February 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cisco_secure_email_gateway Cisco Secure Email Gateway

3 participants

@efd6 @elasticmachine @kcreddy