Skip to content

Conversation

@gpop63
Copy link
Contributor

@gpop63 gpop63 commented Sep 10, 2023

What does this PR do?

Adds dimensions for connection data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

scrnli_9_21_2023_3-01-07 PM

@elasticmachine
Copy link

elasticmachine commented Sep 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-10T21:35:46.703+0000

  • Duration: 31 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 2
Total 33

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (29/29) 💚
Lines 95.522% (192/201)
Conditionals 100.0% (0/0) 💚
@gpop63 gpop63 self-assigned this Sep 10, 2023
@gpop63 gpop63 mentioned this pull request Sep 10, 2023
30 tasks
@gpop63 gpop63 marked this pull request as ready for review September 21, 2023 19:54
@gpop63 gpop63 requested a review from a team as a code owner September 21, 2023 19:54
- external: ecs
name: container.id
dimension: true
- external: ecs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NATS can be deployed nearly anywhere; on bare metal, in a VM, as a container, inside K8S, on a device, or whichever environment you choose.

Due to this, i would recommend having all common dimension fields included in the list. Please have a look at the TSDB migration guidelines document.

Please have it changed on all PRs, if missing.

# newer versions go on top
- version: "1.3.3"
changes:
- description: Add connection data stream dimensions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have it corrected as - Added dimensions mapping to connection data stream.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gpop63 and others added 2 commits October 11, 2023 00:34
Co-authored-by: Agi K Thomas <101976829+agithomas@users.noreply.github.com>
@gpop63 gpop63 merged commit ae728fa into elastic:main Oct 10, 2023
@elasticmachine
Copy link

Package nats - 1.3.5 containing this change is available at https://epr.elastic.co/search?package=nats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants