- Notifications
You must be signed in to change notification settings - Fork 513
[NATS] Add connection data stream dimensions #7739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌐 Coverage report
|
| - external: ecs | ||
| name: container.id | ||
| dimension: true | ||
| - external: ecs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NATS can be deployed nearly anywhere; on bare metal, in a VM, as a container, inside K8S, on a device, or whichever environment you choose.
Due to this, i would recommend having all common dimension fields included in the list. Please have a look at the TSDB migration guidelines document.
Please have it changed on all PRs, if missing.
This reverts commit af76311.
packages/nats/changelog.yml Outdated
| # newer versions go on top | ||
| - version: "1.3.3" | ||
| changes: | ||
| - description: Add connection data stream dimensions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have it corrected as - Added dimensions mapping to connection data stream.
agithomas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Agi K Thomas <101976829+agithomas@users.noreply.github.com>
| Package nats - 1.3.5 containing this change is available at https://epr.elastic.co/search?package=nats |
What does this PR do?
Adds dimensions for
connectiondata stream.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots