Skip to content

Conversation

@chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Aug 17, 2023

What does this PR do?

Adjust a Grok pattern applied to log.file.path so that it matches Windows-style paths like V:\\DATA\\mail_logs.@20230817T054656.s as well as Unix-style paths like /data/mail_logs.@20230817T054656.s.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Doesn't break existing tests:

cd packages/cisco_secure_email_gateway elastic-package test 

Related issues

@chrisberkhout chrisberkhout added Team:Security-External Integrations bugfix Pull request that fixes a bug issue labels Aug 17, 2023
@chrisberkhout chrisberkhout self-assigned this Aug 17, 2023
@chrisberkhout chrisberkhout requested a review from a team as a code owner August 17, 2023 16:48
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Aug 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-17T16:50:10.373+0000

  • Duration: 16 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 83.333% (10/12) 👎 -11.111
Classes 83.333% (10/12) 👎 -11.111
Methods 89.286% (50/56) 👍 3.333
Lines 86.667% (598/690) 👍 0.643
Conditionals 100.0% (0/0) 💚
@chrisberkhout chrisberkhout merged commit a26704d into elastic:main Aug 21, 2023
@chrisberkhout chrisberkhout deleted the cisco_secure_email_gateway-win-paths branch August 21, 2023 07:04
@elasticmachine
Copy link

Package cisco_secure_email_gateway - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=cisco_secure_email_gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_secure_email_gateway Cisco Secure Email Gateway

4 participants