Skip to content

Conversation

@brijesh-elastic
Copy link
Collaborator

Type of change

  • Enhancement

What does this PR do?

  • Add user.geo.*, user.organization.*, and asset categorization mappings.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/entityanalytics_okta directory.
  • Run the following command to run tests.

elastic-package test

Automated Test

2023/08/11 15:20:19 DEBUG Enable verbose logging Run test suite for the package Run static tests for the package --- Test results for package: entityanalytics_okta - START --- ╭──────────────────────┬─────────────┬───────────┬──────────────────────────┬────────┬──────────────╮ │ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │ TIME ELAPSED │ ├──────────────────────┼─────────────┼───────────┼──────────────────────────┼────────┼──────────────┤ │ entityanalytics_okta │ user │ static │ Verify sample_event.json │ PASS │ 120.818395ms │ ╰──────────────────────┴─────────────┴───────────┴──────────────────────────┴────────┴──────────────╯ --- Test results for package: entityanalytics_okta - END --- Done Run system tests for the package 2023/08/11 15:20:20 DEBUG Running system tests for data stream 2023/08/11 15:20:20 DEBUG running test with configuration 'default' 2023/08/11 15:20:20 DEBUG setting up service... 2023/08/11 15:20:20 DEBUG setting up service using Docker Compose service deployer 2023/08/11 15:20:20 DEBUG running command: /usr/local/bin/docker-compose version --short 2023/08/11 15:20:20 DEBUG Determined Docker Compose version: 1.29.2, the tool will use Compose V1 2023/08/11 15:20:20 DEBUG output command: /usr/bin/docker network inspect elastic-package-stack_default 2023/08/11 15:20:20 DEBUG running command: /usr/local/bin/docker-compose -f /root/integrations/packages/entityanalytics_okta/_dev/deploy/docker/docker-compose.yml -p elastic-package-service up --build -d Creating network "elastic-package-service_default" with the default driver Creating elastic-package-service_entityanalytics_okta_1 ... done 2023/08/11 15:20:22 DEBUG running command: /usr/local/bin/docker-compose -f /root/integrations/packages/entityanalytics_okta/_dev/deploy/docker/docker-compose.yml -p elastic-package-service ps -q 2023/08/11 15:20:22 DEBUG Wait for healthy containers: 987be506862b30e94e21b0cff0a0068a5e22e413f65aaca2d3f53f5258cf8c0f 2023/08/11 15:20:22 DEBUG output command: /usr/bin/docker inspect 987be506862b30e94e21b0cff0a0068a5e22e413f65aaca2d3f53f5258cf8c0f 2023/08/11 15:20:22 DEBUG Container status: {"Config":{"Image":"docker.elastic.co/observability/stream:v0.10.0","Labels":{"BRANCH_NAME":"v0.10.0","GIT_SHA":"2a076c9b1acdf1c35b5f5c2f8c23904c7c2c441a","GO_VERSION":"1.19.5","TIMESTAMP":"2023-01-30_11:29","com.docker.compose.config-hash":"cdd887d3c90592da5f89631af4604b333c1035986647afaa25239c160a8311be","com.docker.compose.container-number":"1","com.docker.compose.oneoff":"False","com.docker.compose.project":"elastic-package-service","com.docker.compose.project.config_files":"/root/integrations/packages/entityanalytics_okta/_dev/deploy/docker/docker-compose.yml","com.docker.compose.project.working_dir":"/root/integrations/packages/entityanalytics_okta/_dev/deploy/docker","com.docker.compose.service":"entityanalytics_okta","com.docker.compose.version":"1.29.2"}},"ID":"987be506862b30e94e21b0cff0a0068a5e22e413f65aaca2d3f53f5258cf8c0f","State":{"Status":"running","ExitCode":0,"Health":null}} 2023/08/11 15:20:22 DEBUG run command: /usr/bin/docker network connect elastic-package-stack_default elastic-package-service_entityanalytics_okta_1 2023/08/11 15:20:22 DEBUG adding service container elastic-package-service_entityanalytics_okta_1 internal ports to context 2023/08/11 15:20:22 DEBUG running command: /usr/local/bin/docker-compose -f /root/integrations/packages/entityanalytics_okta/_dev/deploy/docker/docker-compose.yml -p elastic-package-service config 2023/08/11 15:20:23 DEBUG Installing package... 2023/08/11 15:20:23 DEBUG GET https://127.0.0.1:5601/api/status 2023/08/11 15:20:23 DEBUG Build directory: /root/integrations/build/packages/entityanalytics_okta/0.3.0 2023/08/11 15:20:23 DEBUG Clear target directory (path: /root/integrations/build/packages/entityanalytics_okta/0.3.0) 2023/08/11 15:20:23 DEBUG Copy package content (source: /root/integrations/packages/entityanalytics_okta) 2023/08/11 15:20:23 DEBUG Copy license file if needed 2023/08/11 15:20:23 INFO License text found in "/root/integrations/LICENSE.txt" will be included in package 2023/08/11 15:20:23 DEBUG Encode dashboards 2023/08/11 15:20:23 DEBUG Resolve external fields 2023/08/11 15:20:23 DEBUG Package has external dependencies defined 2023/08/11 15:20:23 DEBUG data_stream/user/fields/base-fields.yml: source file hasn't been changed 2023/08/11 15:20:23 DEBUG data_stream/user/fields/beats.yml: source file hasn't been changed 2023/08/11 15:20:23 DEBUG data_stream/user/fields/ecs.yml: source file hasn't been changed 2023/08/11 15:20:23 DEBUG data_stream/user/fields/fields.yml: source file hasn't been changed 2023/08/11 15:20:23 INFO Import ECS mappings into the built package (technical preview) 2023/08/11 15:20:23 DEBUG Build zipped package 2023/08/11 15:20:23 DEBUG Compress using archiver.Zip (destination: /root/integrations/build/packages/entityanalytics_okta-0.3.0.zip) 2023/08/11 15:20:23 DEBUG Create work directory for archiving: /tmp/elastic-package-2074875161/entityanalytics_okta-0.3.0 2023/08/11 15:20:23 DEBUG Skip validation of the built .zip package 2023/08/11 15:20:23 DEBUG POST https://127.0.0.1:5601/api/fleet/epm/packages 2023/08/11 15:20:25 DEBUG creating test policy... 2023/08/11 15:20:25 DEBUG POST https://127.0.0.1:5601/api/fleet/agent_policies 2023/08/11 15:20:30 DEBUG adding package data stream to test policy... 2023/08/11 15:20:30 DEBUG POST https://127.0.0.1:5601/api/fleet/package_policies 2023/08/11 15:20:33 DEBUG deleting old data in data stream... 2023/08/11 15:20:33 DEBUG found 0 hits in logs-entityanalytics_okta.user-ep data stream: index_not_found_exception: no such index [logs-entityanalytics_okta.user-ep] Status=404 2023/08/11 15:20:33 DEBUG GET https://127.0.0.1:5601/api/fleet/agents 2023/08/11 15:20:33 DEBUG filter agents using criteria: NamePrefix=docker-fleet-agent 2023/08/11 15:20:33 DEBUG found 1 enrolled agent(s) 2023/08/11 15:20:33 DEBUG GET https://127.0.0.1:5601/api/fleet/agent_policies/7ef58480-382c-11ee-a527-8f89666e4939 2023/08/11 15:20:33 DEBUG assigning package data stream to agent... 2023/08/11 15:20:33 DEBUG PUT https://127.0.0.1:5601/api/fleet/agents/3b1e5884-6b84-4412-bb73-57ab61bf0c09/reassign 2023/08/11 15:20:35 DEBUG GET https://127.0.0.1:5601/api/fleet/agents/3b1e5884-6b84-4412-bb73-57ab61bf0c09 2023/08/11 15:20:35 DEBUG Agent data: {"id":"3b1e5884-6b84-4412-bb73-57ab61bf0c09","policy_id":"7ef58480-382c-11ee-a527-8f89666e4939","local_metadata":{"host":{"name":"docker-fleet-agent"}}} 2023/08/11 15:20:35 DEBUG Wait until the policy (ID: 7ef58480-382c-11ee-a527-8f89666e4939, revision: 2) is assigned to the agent (ID: 3b1e5884-6b84-4412-bb73-57ab61bf0c09)... 2023/08/11 15:20:37 DEBUG GET https://127.0.0.1:5601/api/fleet/agents/3b1e5884-6b84-4412-bb73-57ab61bf0c09 2023/08/11 15:20:37 DEBUG Agent data: {"id":"3b1e5884-6b84-4412-bb73-57ab61bf0c09","policy_id":"7ef58480-382c-11ee-a527-8f89666e4939","local_metadata":{"host":{"name":"docker-fleet-agent"}}} 2023/08/11 15:20:37 DEBUG Wait until the policy (ID: 7ef58480-382c-11ee-a527-8f89666e4939, revision: 2) is assigned to the agent (ID: 3b1e5884-6b84-4412-bb73-57ab61bf0c09)... 2023/08/11 15:20:39 DEBUG GET https://127.0.0.1:5601/api/fleet/agents/3b1e5884-6b84-4412-bb73-57ab61bf0c09 2023/08/11 15:20:39 DEBUG Agent data: {"id":"3b1e5884-6b84-4412-bb73-57ab61bf0c09","policy_id":"7ef58480-382c-11ee-a527-8f89666e4939","local_metadata":{"host":{"name":"docker-fleet-agent"}}} 2023/08/11 15:20:39 DEBUG Wait until the policy (ID: 7ef58480-382c-11ee-a527-8f89666e4939, revision: 2) is assigned to the agent (ID: 3b1e5884-6b84-4412-bb73-57ab61bf0c09)... 2023/08/11 15:20:41 DEBUG GET https://127.0.0.1:5601/api/fleet/agents/3b1e5884-6b84-4412-bb73-57ab61bf0c09 2023/08/11 15:20:41 DEBUG Agent data: {"id":"3b1e5884-6b84-4412-bb73-57ab61bf0c09","policy_id":"7ef58480-382c-11ee-a527-8f89666e4939","policy_revision":2,"local_metadata":{"host":{"name":"docker-fleet-agent"}}} 2023/08/11 15:20:41 DEBUG Policy revision assigned to the agent (ID: 3b1e5884-6b84-4412-bb73-57ab61bf0c09)... 2023/08/11 15:20:41 DEBUG checking for expected data in data stream... 2023/08/11 15:20:41 DEBUG found 0 hits in logs-entityanalytics_okta.user-ep data stream: index_not_found_exception: no such index [logs-entityanalytics_okta.user-ep] Status=404 2023/08/11 15:20:42 DEBUG found 0 hits in logs-entityanalytics_okta.user-ep data stream: index_not_found_exception: no such index [logs-entityanalytics_okta.user-ep] Status=404 2023/08/11 15:20:43 DEBUG found 0 hits in logs-entityanalytics_okta.user-ep data stream: index_not_found_exception: no such index [logs-entityanalytics_okta.user-ep] Status=404 2023/08/11 15:20:44 DEBUG found 0 hits in logs-entityanalytics_okta.user-ep data stream 2023/08/11 15:20:45 DEBUG found 3 hits in logs-entityanalytics_okta.user-ep data stream 2023/08/11 15:20:45 DEBUG check whether or not synthetics is enabled (component template logs-entityanalytics_okta.user@package)... 2023/08/11 15:20:45 DEBUG data stream logs-entityanalytics_okta.user-ep has synthetics enabled: false 2023/08/11 15:20:45 DEBUG reassigning original policy back to agent... 2023/08/11 15:20:45 DEBUG PUT https://127.0.0.1:5601/api/fleet/agents/3b1e5884-6b84-4412-bb73-57ab61bf0c09/reassign 2023/08/11 15:20:46 DEBUG GET https://127.0.0.1:5601/api/fleet/agents/3b1e5884-6b84-4412-bb73-57ab61bf0c09 2023/08/11 15:20:46 DEBUG Agent data: {"id":"3b1e5884-6b84-4412-bb73-57ab61bf0c09","policy_id":"elastic-agent-managed-ep","local_metadata":{"host":{"name":"docker-fleet-agent"}}} 2023/08/11 15:20:46 DEBUG Wait until the policy (ID: elastic-agent-managed-ep, revision: 3) is assigned to the agent (ID: 3b1e5884-6b84-4412-bb73-57ab61bf0c09)... 2023/08/11 15:20:48 DEBUG GET https://127.0.0.1:5601/api/fleet/agents/3b1e5884-6b84-4412-bb73-57ab61bf0c09 2023/08/11 15:20:48 DEBUG Agent data: {"id":"3b1e5884-6b84-4412-bb73-57ab61bf0c09","policy_id":"elastic-agent-managed-ep","local_metadata":{"host":{"name":"docker-fleet-agent"}}} 2023/08/11 15:20:48 DEBUG Wait until the policy (ID: elastic-agent-managed-ep, revision: 3) is assigned to the agent (ID: 3b1e5884-6b84-4412-bb73-57ab61bf0c09)... 2023/08/11 15:20:50 DEBUG GET https://127.0.0.1:5601/api/fleet/agents/3b1e5884-6b84-4412-bb73-57ab61bf0c09 2023/08/11 15:20:50 DEBUG Agent data: {"id":"3b1e5884-6b84-4412-bb73-57ab61bf0c09","policy_id":"elastic-agent-managed-ep","local_metadata":{"host":{"name":"docker-fleet-agent"}}} 2023/08/11 15:20:50 DEBUG Wait until the policy (ID: elastic-agent-managed-ep, revision: 3) is assigned to the agent (ID: 3b1e5884-6b84-4412-bb73-57ab61bf0c09)... 2023/08/11 15:20:52 DEBUG GET https://127.0.0.1:5601/api/fleet/agents/3b1e5884-6b84-4412-bb73-57ab61bf0c09 2023/08/11 15:20:52 DEBUG Agent data: {"id":"3b1e5884-6b84-4412-bb73-57ab61bf0c09","policy_id":"elastic-agent-managed-ep","policy_revision":3,"local_metadata":{"host":{"name":"docker-fleet-agent"}}} 2023/08/11 15:20:52 DEBUG Policy revision assigned to the agent (ID: 3b1e5884-6b84-4412-bb73-57ab61bf0c09)... 2023/08/11 15:20:52 DEBUG deleting test policy... 2023/08/11 15:20:52 DEBUG POST https://127.0.0.1:5601/api/fleet/agent_policies/delete 2023/08/11 15:20:56 DEBUG DELETE https://127.0.0.1:5601/api/fleet/epm/packages/entityanalytics_okta-0.3.0 2023/08/11 15:20:57 DEBUG tearing down service... 2023/08/11 15:20:57 DEBUG tearing down service using Docker Compose runner 2023/08/11 15:20:57 DEBUG running command: /usr/local/bin/docker-compose version --short 2023/08/11 15:20:58 DEBUG Determined Docker Compose version: 1.29.2, the tool will use Compose V1 2023/08/11 15:20:58 DEBUG running command: /usr/local/bin/docker-compose -f /root/integrations/packages/entityanalytics_okta/_dev/deploy/docker/docker-compose.yml -p elastic-package-service logs 2023/08/11 15:20:58 INFO Write container logs to file: /root/integrations/build/container-logs/entityanalytics_okta-1691747458790449640.log 2023/08/11 15:20:58 DEBUG running command: /usr/local/bin/docker-compose -f /root/integrations/packages/entityanalytics_okta/_dev/deploy/docker/docker-compose.yml -p elastic-package-service down --volumes Stopping elastic-package-service_entityanalytics_okta_1 ... done Removing elastic-package-service_entityanalytics_okta_1 ... done Removing network elastic-package-service_default 2023/08/11 15:20:59 DEBUG deleting data in data stream... 2023/08/11 15:20:59 DEBUG Dump Elastic stack data 2023/08/11 15:20:59 DEBUG Dump stack logs (location: /tmp/test-system-703197751) 2023/08/11 15:20:59 DEBUG Dump stack logs for elasticsearch 2023/08/11 15:20:59 DEBUG running command: /usr/local/bin/docker-compose version --short 2023/08/11 15:21:00 DEBUG Determined Docker Compose version: 1.29.2, the tool will use Compose V1 2023/08/11 15:21:00 DEBUG running command: /usr/local/bin/docker-compose -f /root/.elastic-package/profiles/default/stack/snapshot.yml -p elastic-package-stack logs elasticsearch 2023/08/11 15:21:01 DEBUG Dump stack logs for elastic-agent 2023/08/11 15:21:01 DEBUG running command: /usr/local/bin/docker-compose version --short 2023/08/11 15:21:01 DEBUG Determined Docker Compose version: 1.29.2, the tool will use Compose V1 2023/08/11 15:21:01 DEBUG running command: /usr/local/bin/docker-compose -f /root/.elastic-package/profiles/default/stack/snapshot.yml -p elastic-package-stack logs elastic-agent 2023/08/11 15:21:02 DEBUG running command: /usr/local/bin/docker-compose version --short 2023/08/11 15:21:03 DEBUG Determined Docker Compose version: 1.29.2, the tool will use Compose V1 2023/08/11 15:21:03 DEBUG run command: /usr/bin/docker cp elastic-package-stack_elastic-agent_1:/usr/share/elastic-agent/state/data/logs/ /tmp/test-system-703197751/logs/elastic-agent-internal 2023/08/11 15:21:03 DEBUG Dump stack logs for fleet-server 2023/08/11 15:21:03 DEBUG running command: /usr/local/bin/docker-compose version --short 2023/08/11 15:21:03 DEBUG Determined Docker Compose version: 1.29.2, the tool will use Compose V1 2023/08/11 15:21:03 DEBUG running command: /usr/local/bin/docker-compose -f /root/.elastic-package/profiles/default/stack/snapshot.yml -p elastic-package-stack logs fleet-server 2023/08/11 15:21:04 DEBUG running command: /usr/local/bin/docker-compose version --short 2023/08/11 15:21:05 DEBUG Determined Docker Compose version: 1.29.2, the tool will use Compose V1 2023/08/11 15:21:05 DEBUG run command: /usr/bin/docker cp elastic-package-stack_fleet-server_1:/usr/share/elastic-agent/state/data/logs/ /tmp/test-system-703197751/logs/fleet-server-internal 2023/08/11 15:21:05 DEBUG Dump stack logs for kibana 2023/08/11 15:21:05 DEBUG running command: /usr/local/bin/docker-compose version --short 2023/08/11 15:21:05 DEBUG Determined Docker Compose version: 1.29.2, the tool will use Compose V1 2023/08/11 15:21:05 DEBUG running command: /usr/local/bin/docker-compose -f /root/.elastic-package/profiles/default/stack/snapshot.yml -p elastic-package-stack logs kibana 2023/08/11 15:21:06 DEBUG Dump stack logs for package-registry 2023/08/11 15:21:06 DEBUG running command: /usr/local/bin/docker-compose version --short 2023/08/11 15:21:07 DEBUG Determined Docker Compose version: 1.29.2, the tool will use Compose V1 2023/08/11 15:21:07 DEBUG running command: /usr/local/bin/docker-compose -f /root/.elastic-package/profiles/default/stack/snapshot.yml -p elastic-package-stack logs package-registry 2023/08/11 15:21:08 DEBUG skipped malformed docker-compose log line: Attaching to elastic-package-stack_elastic-agent_1 --- Test results for package: entityanalytics_okta - START --- ╭──────────────────────┬─────────────┬───────────┬───────────┬────────┬───────────────╮ │ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │ TIME ELAPSED │ ├──────────────────────┼─────────────┼───────────┼───────────┼────────┼───────────────┤ │ entityanalytics_okta │ user │ system │ default │ PASS │ 25.484211899s │ ╰──────────────────────┴─────────────┴───────────┴───────────┴────────┴───────────────╯ --- Test results for package: entityanalytics_okta - END --- Done Run asset tests for the package 2023/08/11 15:21:08 DEBUG installing package... 2023/08/11 15:21:08 DEBUG GET https://127.0.0.1:5601/api/status 2023/08/11 15:21:08 DEBUG Build directory: /root/integrations/build/packages/entityanalytics_okta/0.3.0 2023/08/11 15:21:08 DEBUG Clear target directory (path: /root/integrations/build/packages/entityanalytics_okta/0.3.0) 2023/08/11 15:21:08 DEBUG Copy package content (source: /root/integrations/packages/entityanalytics_okta) 2023/08/11 15:21:08 DEBUG Copy license file if needed 2023/08/11 15:21:08 INFO License text found in "/root/integrations/LICENSE.txt" will be included in package 2023/08/11 15:21:08 DEBUG Encode dashboards 2023/08/11 15:21:08 DEBUG Resolve external fields 2023/08/11 15:21:08 DEBUG Package has external dependencies defined 2023/08/11 15:21:08 DEBUG data_stream/user/fields/base-fields.yml: source file hasn't been changed 2023/08/11 15:21:08 DEBUG data_stream/user/fields/beats.yml: source file hasn't been changed 2023/08/11 15:21:08 DEBUG data_stream/user/fields/ecs.yml: source file hasn't been changed 2023/08/11 15:21:08 DEBUG data_stream/user/fields/fields.yml: source file hasn't been changed 2023/08/11 15:21:08 INFO Import ECS mappings into the built package (technical preview) 2023/08/11 15:21:08 DEBUG Build zipped package 2023/08/11 15:21:08 DEBUG Compress using archiver.Zip (destination: /root/integrations/build/packages/entityanalytics_okta-0.3.0.zip) 2023/08/11 15:21:08 DEBUG Create work directory for archiving: /tmp/elastic-package-4102691143/entityanalytics_okta-0.3.0 2023/08/11 15:21:08 DEBUG Skip validation of the built .zip package 2023/08/11 15:21:08 DEBUG POST https://127.0.0.1:5601/api/fleet/epm/packages 2023/08/11 15:21:09 DEBUG removing package... 2023/08/11 15:21:09 DEBUG DELETE https://127.0.0.1:5601/api/fleet/epm/packages/entityanalytics_okta-0.3.0 --- Test results for package: entityanalytics_okta - START --- ╭──────────────────────┬─────────────┬───────────┬───────────────────────────────────────────────────────────────────────────────┬────────┬──────────────╮ │ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │ TIME ELAPSED │ ├──────────────────────┼─────────────┼───────────┼───────────────────────────────────────────────────────────────────────────────┼────────┼──────────────┤ │ entityanalytics_okta │ │ asset │ dashboard entityanalytics_okta-e5242a60-0f35-11ee-8319-1d33c4a0c7ae is loaded │ PASS │ 1.189µs │ │ entityanalytics_okta │ │ asset │ search entityanalytics_okta-d4f05110-0f7a-11ee-8319-1d33c4a0c7ae is loaded │ PASS │ 787ns │ │ entityanalytics_okta │ user │ asset │ index_template logs-entityanalytics_okta.user is loaded │ PASS │ 683ns │ │ entityanalytics_okta │ user │ asset │ ingest_pipeline logs-entityanalytics_okta.user-0.3.0 is loaded │ PASS │ 706ns │ ╰──────────────────────┴─────────────┴───────────┴───────────────────────────────────────────────────────────────────────────────┴────────┴──────────────╯ --- Test results for package: entityanalytics_okta - END --- Done Run pipeline tests for the package --- Test results for package: entityanalytics_okta - START --- ╭──────────────────────┬─────────────┬───────────┬────────────────┬────────┬──────────────╮ │ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │ TIME ELAPSED │ ├──────────────────────┼─────────────┼───────────┼────────────────┼────────┼──────────────┤ │ entityanalytics_okta │ user │ pipeline │ test-user.json │ PASS │ 8.836524ms │ ╰──────────────────────┴─────────────┴───────────┴────────────────┴────────┴──────────────╯ --- Test results for package: entityanalytics_okta - END --- Done 
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner August 16, 2023 11:24
@elasticmachine
Copy link

elasticmachine commented Aug 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-16T11:24:57.484+0000

  • Duration: 15 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (9/9) 💚 26.667
Lines 90.675% (564/622) 👎 -9.325
Conditionals 100.0% (0/0) 💚
@ShourieG
Copy link
Contributor

ShourieG commented Sep 6, 2023

@brijesh-elastic for all the new fields added with ignore_empty_value param, will the attribute keys always exist or do we also need to add ignore_missing to some of them also ?

@ShourieG ShourieG self-requested a review September 6, 2023 11:17
@ShourieG ShourieG added 8.10 candidate integration Label used for meta issues tracking each integration Team:Security-External Integrations labels Sep 6, 2023
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kcreddy
Copy link
Contributor

kcreddy commented Sep 6, 2023

for all the new fields added with ignore_empty_value param, will the attribute keys always exist or do we also need to add ignore_missing to some of them also ?

Marius simulated this here and ignore_empty_value: true should suffice.

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShourieG ShourieG merged commit 84233dc into elastic:main Sep 6, 2023
@elasticmachine
Copy link

Package entityanalytics_okta - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=entityanalytics_okta

@andrewkroh andrewkroh added the Integration:entityanalytics_okta Okta Entity Analytics label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.10 candidate Integration:entityanalytics_okta Okta Entity Analytics integration Label used for meta issues tracking each integration

5 participants