Skip to content

[network_traffic] Fix field type for send_headers from bool to text #5433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 2, 2023
Merged

[network_traffic] Fix field type for send_headers from bool to text #5433

merged 3 commits into from
Mar 2, 2023

Conversation

@P1llus
Copy link
Member

@P1llus P1llus commented Mar 2, 2023

What does this PR do?

Manifest.yml defined the send_headers UI option as the wrong type (bool not text), this PR fixes that.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@P1llus P1llus requested a review from a team as a code owner March 2, 2023 14:58
@elasticmachine
Copy link

elasticmachine commented Mar 2, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@P1llus P1llus added the Integration:network_traffic Network Packet Capture label Mar 2, 2023
ShourieG
ShourieG approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@elasticmachine
Copy link

elasticmachine commented Mar 2, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-02T15:27:44.739+0000

  • Duration: 74 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 173
Skipped 0
Total 173

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Mar 2, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 71.875% (46/64) 👎 -20.808
Lines 100.0% (0/0) 💚 9.184
Conditionals 100.0% (0/0) 💚
@P1llus P1llus merged commit 915e4db into elastic:main Mar 2, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 2, 2023

Package network_traffic - 1.9.2 containing this change is available at https://epr.elastic.co/search?package=network_traffic
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@P1llus @agithomas
[network_traffic] Fix field type for send_headers from bool to text (e…
4929e28 
…lastic#5433) * [network_traffic] Fix field type for send_headers from bool to text * update changelog * changing field to multi: true, and iterating over it as it is expecting an array
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@P1llus @agithomas
[network_traffic] Fix field type for send_headers from bool to text (e…
60502c1 
…lastic#5433) * [network_traffic] Fix field type for send_headers from bool to text * update changelog * changing field to multi: true, and iterating over it as it is expecting an array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:network_traffic Network Packet Capture

3 participants

@P1llus @elasticmachine @ShourieG