Skip to content

cisco_meraki: capture flows firewall rules #5138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

cisco_meraki: capture flows firewall rules #5138

merged 1 commit into from
Feb 1, 2023

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Jan 30, 2023

What does this PR do?

This captures flows' firewall rules.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 self-assigned this Jan 30, 2023
@efd6 efd6 force-pushed the 5086-cisco_meraki branch from 0d9faad to d05189d Compare January 30, 2023 01:43
@efd6 efd6 force-pushed the 5086-cisco_meraki branch from d05189d to e1e8157 Compare January 30, 2023 01:44
@elasticmachine
Copy link

elasticmachine commented Jan 30, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-30T01:45:11.045+0000

  • Duration: 17 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@efd6 efd6 marked this pull request as ready for review January 30, 2023 01:57
@efd6 efd6 requested a review from a team as a code owner January 30, 2023 01:57
@elasticmachine
Copy link

elasticmachine commented Jan 30, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine
Copy link

elasticmachine commented Jan 30, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚 2.673
Classes 100.0% (9/9) 💚 2.673
Methods 100.0% (64/64) 💚 7.84
Lines 98.027% (1093/1115) 👍 5.546
Conditionals 100.0% (0/0) 💚
ShourieG
ShourieG approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@efd6 efd6 merged commit cfdc5eb into elastic:main Feb 1, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 1, 2023

Package cisco_meraki - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki
@efd6 efd6 deleted the 5086-cisco_meraki branch February 5, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cisco_meraki Cisco Meraki

4 participants

@efd6 @elasticmachine @kcreddy @ShourieG