Skip to content

[cisco_meraki] Add feature to remove original event #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 28, 2022
Merged

[cisco_meraki] Add feature to remove original event #4097

merged 7 commits into from
Sep 28, 2022

Conversation

@LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Aug 30, 2022

What does this PR do?

Add the ability to remove event.original when preserve_original_event is not in tags.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@LaZyDK LaZyDK requested a review from a team as a code owner August 30, 2022 10:27
@LaZyDK
Copy link
Contributor Author

LaZyDK commented Aug 30, 2022

@P1llus test :)
@elasticmachine
Copy link

elasticmachine commented Aug 30, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-28T08:42:13.882+0000

  • Duration: 18 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@P1llus
Copy link
Member

P1llus commented Aug 30, 2022

/test
@elasticmachine
Copy link

elasticmachine commented Aug 30, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 100.0% (65/65) 💚
Lines 98.851% (1118/1131) ❕
Conditionals 100.0% (0/0) 💚
efd6
efd6 reviewed Aug 30, 2022
View reviewed changes
LaZyDK added 2 commits August 31, 2022 07:54
@LaZyDK
Update changelog.yml
8c4c86a 
bump version
@LaZyDK
Update manifest.yml
fe814a5 
bump version
@elasticmachine
Copy link

elasticmachine commented Sep 7, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@andrewkroh andrewkroh added enhancement New feature or request Integration:cisco_meraki Cisco Meraki labels Sep 7, 2022
@andrewkroh
Copy link
Member

andrewkroh commented Sep 7, 2022

/test
@P1llus P1llus self-assigned this Sep 28, 2022
@P1llus
Copy link
Member

P1llus commented Sep 28, 2022

/test
@P1llus P1llus self-requested a review September 28, 2022 08:42
@elasticmachine
Copy link

elasticmachine commented Sep 28, 2022

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@P1llus P1llus merged commit 231be0d into elastic:main Sep 28, 2022
@andrewkroh andrewkroh mentioned this pull request Sep 29, 2022
Merged
@LaZyDK LaZyDK deleted the patch-2 branch October 5, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cisco_meraki Cisco Meraki

5 participants

@LaZyDK @elasticmachine @P1llus @andrewkroh @efd6