Skip to content

[Windows enhancement ]Added processor field for service data stream in windows package #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 12, 2022
Merged

[Windows enhancement ]Added processor field for service data stream in windows package #3618

merged 5 commits into from
Jul 12, 2022

Conversation

@ManojS-shetty
Copy link
Contributor

@ManojS-shetty ManojS-shetty commented Jun 29, 2022 •
edited
Loading

  • Enhancement

What does this PR do?

This PR adds the processors for the windows integration UI for windows service data stream, So that users can provide the processors input from the UI and filter out the services based on service display name or service state.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics and logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone the PR in windows machine.
  • Build the integration using elastic-package commands
  • Goto Integration page -> Search for windows -> Update to the latest package version
  • Add the windows integration.
  • Under the windows service metrics find the Processors yaml input box
  • Specify the Processors for filtering the windows services.

Related issues
@ManojS-shetty ManojS-shetty self-assigned this Jun 29, 2022
@elasticmachine
Copy link

elasticmachine commented Jun 29, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-04T09:10:50.316+0000

  • Duration: 16 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 126
Skipped 0
Total 126

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Jun 29, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -8.441
Classes 87.5% (7/8) 👎 -8.441
Methods 84.884% (73/86) 👎 -2.972
Lines 93.376% (4962/5314) 👍 5.884
Conditionals 100.0% (0/0) 💚
@ManojS-shetty ManojS-shetty requested review from a team and belimawr June 29, 2022 07:26
belimawr
belimawr approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an integrations expert, but LGTM.
@belimawr
Copy link
Contributor

@ManojS-shetty I've just realised this PR is still a draft. Is there anything missing or can it be promoted to a normal PR?
@ManojS-shetty ManojS-shetty marked this pull request as ready for review June 30, 2022 10:55
@ManojS-shetty ManojS-shetty requested review from a team as code owners June 30, 2022 10:55
@ManojS-shetty ManojS-shetty requested a review from faec June 30, 2022 10:55
@ManojS-shetty
Copy link
Contributor Author

@ManojS-shetty I've just realised this PR is still a draft. Is there anything missing or can it be promoted to a normal PR?

Yes promoted to normal PR. Thank you:)
efd6
efd6 reviewed Jul 3, 2022
View reviewed changes
ishleenk17
ishleenk17 reviewed Jul 4, 2022
View reviewed changes
efd6
efd6 reviewed Jul 4, 2022
View reviewed changes
@andrewkroh andrewkroh added enhancement New feature or request Integration:windows Windows Team:Service-Integrations Label for the Observability Service Integrations team labels Jul 6, 2022
@ManojS-shetty ManojS-shetty merged commit 6773948 into elastic:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:windows Windows Metricbeat Team:Service-Integrations Label for the Observability Service Integrations team

7 participants

@ManojS-shetty @elasticmachine @belimawr @faec @efd6 @ishleenk17 @andrewkroh