[cisco_meraki_metrics] Add network_health data stream #15663
Conversation
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh added documentation 
Co-authored-by: Mykola Kmet <mykola.kmet@elastic.co>
| /test |
| @@ -0,0 +1,22 @@ | |||
| metricsets: ["network_health"] | |||
| apiBaseURL: {{apiBaseUrl}} | |||
There was a problem hiding this comment.
just double checking the capitalisation ;)
...es/cisco_meraki_metrics/data_stream/network_health/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
| @@ -0,0 +1,23 @@ | |||
| - name: host | |||
There was a problem hiding this comment.
isn't all this in the default ECS mapping?
There was a problem hiding this comment.
I've tried removing them but I get this error when building the package:
FAILURE DETAILS: cisco_meraki_metrics/network_health Verify sample_event.json: [0] field "host.ip" is not normalized as expected: expected array, found "172.21.0.4" (string) [1] field "host.mac" is not normalized as expected: expected array, found "02-42-AC-15-00-04" (string) | @@ -0,0 +1,12 @@ | |||
| - name: data_stream.type | |||
There was a problem hiding this comment.
all these are also in the ECS mappings, we can remove this file.
There was a problem hiding this comment.
I've tried removing the base-fields file but when building the package I got this error:
Error: building package failed: invalid content found in built zip package: found 4 validation errors: 1. expected field "data_stream.namespace" with type "constant_keyword" not found in datastream "network_health" 2. expected field "@timestamp" with type "date" not found in datastream "network_health" 3. expected field "data_stream.type" with type "constant_keyword" not found in datastream "network_health" 4. expected field "data_stream.dataset" with type "constant_keyword" not found in datastream "network_health" hey @jsoriano 👋 do you know if this will be fixed in the future or did I miss something when removing the fields?
There was a problem hiding this comment.
These cannot be removed from integration packages yet. We are removing this requirement from input packages in next elastic-package version, but it is soon to remove from integration packages.
| - name: organization_id | ||
| type: keyword | ||
| dimension: true | ||
| - name: network |
There was a problem hiding this comment.
i think this is missing lots of fields, and some of the fields at the top level are named incorrectly.
we have organization_id, network_id, network_name at the top level. in addition i see in the beats code:
usage_summary.received.bytes usage_summary.sent.bytes jitter_summaries.jitter_avg jitter_summaries.jitter_max jitter_summaries.jitter_min jitter_summaries.receiver_uplink jitter_summaries.sender_uplink latency_summaries.latency_avg.ms latency_summaries.latency_max.ms latency_summaries.latency_min.ms latency_summaries.receiver_uplink latency_summaries.sender_uplink loss_percentage_summaries.loss_avg.pct loss_percentage_summaries.loss_max.pct loss_percentage_summaries.loss_min.pct loss_percentage_summaries.receiver_uplink loss_percentage_summaries.sender_uplink mos_summaries.mos_avg mos_summaries.mos_max mos_summaries.mos_min mos_summaries.receiver_uplink mos_summaries.sender_uplink There was a problem hiding this comment.
Top fields seem to be organization_id and network. In network field group there is id, name and vpn_peers.
Example doc: https://github.com/elastic/beats/blob/main/x-pack/metricbeat/module/meraki/network_health/_meta/data.json
This reverts commit a6877bc.
This reverts commit 00c2e22.
💚 Build Succeeded
History
cc @gpop63 |
7 participants
Proposed commit message
This PR adds the new
network_healthds.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots