Skip to content

ssi_some: fix template program error to prevent updating fleet health status to degraded #15584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2025
Merged

ssi_some: fix template program error to prevent updating fleet health status to degraded #15584

merged 4 commits into from
Oct 24, 2025

Conversation

@brijesh-elastic
Copy link
Collaborator

@brijesh-elastic brijesh-elastic commented Oct 7, 2025 •
edited
Loading

Proposed commit message

Prevent updating fleet health status to degraded for following packages
when HTTPJSON template value evaluation is empty.

  • atlassian_bitbucket
  • forgerock (Adding a 'Rate Limit Remaining' header in system test rules to prevent empty template evaluation.)
  • httpjson
  • lumos
  • microsoft_exchange_online_message_trace
  • sophos_central
  • tenable_sc
  • ti_eset
  • zerofox
  • zeronetworks

This change bumps minimum Kibana version to ^8.19.4 || ~9.0.7 || ^9.1.4 and
adds do_not_log_failure: true in set processors to avoid updating
fleet health status to degraded.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@brijesh-elastic brijesh-elastic self-assigned this Oct 7, 2025
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner October 7, 2025 07:28
@brijesh-elastic brijesh-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:tenable_sc Tenable Security Center Integration:httpjson Custom API Integration:atlassian_bitbucket Atlassian Bitbucket (Community supported) Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace Integration:forgerock ForgeRock Integration:zeronetworks Zero Networks (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:lumos Lumos (Partner supported) Integration:ti_eset ESET Threat Intelligence (Partner supported) Integration:sophos_central Sophos Central Integration:zerofox ZeroFox (Partner supported) Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Oct 7, 2025
@elasticmachine
Copy link

elasticmachine commented Oct 7, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 7, 2025 •
edited
Loading

🚀 Benchmarks report

Package forgerock 👍(3) 💚(6) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
idm_sync 27777.78 20833.33 -6944.45 (-25%) 💔
am_authentication 20833.33 16949.15 -3884.18 (-18.64%) 💔

To see the full report comment with /test benchmark fullreport
kcreddy
kcreddy reviewed Oct 15, 2025
View reviewed changes
packages/atlassian_bitbucket/changelog.yml Outdated
changes:
- description: Prevent updating fleet health status to degraded.
type: enhancement
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

@kcreddy kcreddy Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/1
link: https://github.com/elastic/integrations/pull/15584
packages/forgerock/changelog.yml Outdated
changes:
- description: Prevent updating fleet health status to degraded.
type: enhancement
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

@kcreddy kcreddy Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/1
link: https://github.com/elastic/integrations/pull/15584
packages/lumos/changelog.yml Outdated
changes:
- description: Prevent updating fleet health status to degraded.
type: enhancement
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

@kcreddy kcreddy Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/1
link: https://github.com/elastic/integrations/pull/15584
packages/httpjson/changelog.yml Outdated
changes:
- description: Prevent updating fleet health status to degraded.
type: enhancement
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

@kcreddy kcreddy Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/1
link: https://github.com/elastic/integrations/pull/15584
packages/microsoft_exchange_online_message_trace/changelog.yml Outdated
changes:
- description: Prevent updating fleet health status to degraded.
type: enhancement
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

@kcreddy kcreddy Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/1
link: https://github.com/elastic/integrations/pull/15584
packages/sophos_central/changelog.yml Outdated
changes:
- description: Prevent updating fleet health status to degraded.
type: enhancement
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

@kcreddy kcreddy Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/1
link: https://github.com/elastic/integrations/pull/15584
packages/tenable_sc/changelog.yml Outdated
changes:
- description: Prevent updating fleet health status to degraded.
type: enhancement
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

@kcreddy kcreddy Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/1
link: https://github.com/elastic/integrations/pull/15584
packages/ti_eset/changelog.yml Outdated
changes:
- description: Prevent updating fleet health status to degraded.
type: enhancement
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

@kcreddy kcreddy Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/1
link: https://github.com/elastic/integrations/pull/15584
packages/zerofox/changelog.yml Outdated
changes:
- description: Prevent updating fleet health status to degraded.
type: enhancement
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

@kcreddy kcreddy Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/1
link: https://github.com/elastic/integrations/pull/15584
packages/zeronetworks/changelog.yml Outdated
changes:
- description: Prevent updating fleet health status to degraded.
type: enhancement
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

@kcreddy kcreddy Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/1
link: https://github.com/elastic/integrations/pull/15584
@ShourieG
Copy link
Contributor

ShourieG commented Oct 15, 2025 •
edited
Loading

@brijesh-elastic @kcreddy, should we not also add 9.1.4 to all kibana versions since the httpjson fix is not in the earlier 9.1.x versions ?
@ShourieG ShourieG self-requested a review October 15, 2025 09:14
ShourieG
ShourieG reviewed Oct 15, 2025
View reviewed changes
packages/atlassian_bitbucket/manifest.yml Outdated
conditions:
kibana:
version: "^8.13.0 || ^9.0.0"
version: "^8.19.4 || ^9.0.7"
Copy link
Contributor

@ShourieG ShourieG Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: "^8.19.4 || ^9.0.7"
version: "^8.19.4 || ~9.0.7 || ^9.1.4"
@elasticmachine
Copy link

elasticmachine commented Oct 15, 2025

💚 Build Succeeded

History

cc @brijesh-elastic
@brijesh-elastic brijesh-elastic merged commit 72b284e into elastic:main Oct 24, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 24, 2025

Package atlassian_bitbucket - 2.6.0 containing this change is available at https://epr.elastic.co/package/atlassian_bitbucket/2.6.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 24, 2025

Package forgerock - 1.22.0 containing this change is available at https://epr.elastic.co/package/forgerock/1.22.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 24, 2025

Package httpjson - 1.24.0 containing this change is available at https://epr.elastic.co/package/httpjson/1.24.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 24, 2025

Package lumos - 1.6.0 containing this change is available at https://epr.elastic.co/package/lumos/1.6.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 24, 2025

Package microsoft_exchange_online_message_trace - 1.29.0 containing this change is available at https://epr.elastic.co/package/microsoft_exchange_online_message_trace/1.29.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 24, 2025

Package sophos_central - 1.20.0 containing this change is available at https://epr.elastic.co/package/sophos_central/1.20.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 24, 2025

Package tenable_sc - 1.32.0 containing this change is available at https://epr.elastic.co/package/tenable_sc/1.32.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 24, 2025

Package ti_eset - 1.8.0 containing this change is available at https://epr.elastic.co/package/ti_eset/1.8.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 24, 2025

Package zerofox - 1.29.0 containing this change is available at https://epr.elastic.co/package/zerofox/1.29.0/
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 24, 2025

Package zeronetworks - 1.19.0 containing this change is available at https://epr.elastic.co/package/zeronetworks/1.19.0/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:atlassian_bitbucket Atlassian Bitbucket (Community supported) Integration:forgerock ForgeRock Integration:httpjson Custom API Integration:lumos Lumos (Partner supported) Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace Integration:sophos_central Sophos Central Integration:tenable_sc Tenable Security Center Integration:ti_eset ESET Threat Intelligence (Partner supported) Integration:zerofox ZeroFox (Partner supported) Integration:zeronetworks Zero Networks (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

4 participants

@brijesh-elastic @elasticmachine @ShourieG @kcreddy