Skip to content

o365: tolerate missing cursor elements when advancing #15154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

o365: tolerate missing cursor elements when advancing #15154

merged 1 commit into from
Sep 4, 2025

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Sep 4, 2025 •
edited
Loading

Proposed commit message

o365: tolerate missing cursor elements when advancing When an error occurs, we may end up without cursor fields. So be more careful when accessing them.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 self-assigned this Sep 4, 2025
@efd6 efd6 added Integration:o365 Microsoft Office 365 bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Sep 4, 2025
@efd6
o365: tolerate missing cursor elements when advancing
91cb70e 
WIP This should never happen, but there is not yet enough information to determine the cause. It may be that we want to raise a health status update in situations like this. My guess is that there was an error, the cursor was damaged and we end up not having parts of the cursor. The question is "How?"
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Sep 4, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine
Copy link

elasticmachine commented Sep 4, 2025

💚 Build Succeeded

cc @efd6
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Sep 4, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@efd6 efd6 marked this pull request as ready for review September 4, 2025 10:13
@efd6 efd6 requested a review from a team as a code owner September 4, 2025 10:13
@elasticmachine
Copy link

elasticmachine commented Sep 4, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@efd6 efd6 requested a review from kcreddy September 4, 2025 10:13
@StacieClark-Elastic StacieClark-Elastic merged commit afe1362 into elastic:main Sep 4, 2025
9 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Sep 4, 2025

Package o365 - 2.26.2 containing this change is available at https://epr.elastic.co/package/o365/2.26.2/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants

@efd6 @elasticmachine @kcreddy @StacieClark-Elastic