Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Aug 19, 2025

Proposed commit message

See title.

This is a resurrection of #14430.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Aug 19, 2025
@efd6 efd6 added enhancement New feature or request Integration:snyk Snyk Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Aug 19, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review August 20, 2025 00:16
@efd6 efd6 requested a review from a team as a code owner August 20, 2025 00:16
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@clement-fouque
Copy link
Contributor

I'm not able to validate it's working as expecting since I still have this issue: #14342

@clement-fouque
Copy link
Contributor

After some more investigation, I'm blocked with this new issue: #15006

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@efd6
Copy link
Contributor Author

efd6 commented Sep 5, 2025

@clement-fouque #15006 is now fixed and I do not have enough information to be able to work on #14342. Can you review this now? Should I close this and redo it again later?

@clement-fouque
Copy link
Contributor

Sorry I didn't understand that you were waiting from me. I'll get back to you next week.

Copy link
Contributor

@clement-fouque clement-fouque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test and it's not working. I believe it's because filtering is made on created_afterand not on updated_after. Therefore, the "update call" is not made.

Since created_at = updated_at when an issue is created, I believe we can change from created_at to updated_at in

?"created_after": (has(state.?cursor.last_created) && !has(state.?cursor.last_updated)) ?

@efd6
Copy link
Contributor Author

efd6 commented Sep 8, 2025

With that change, this will be a breaking change.

@efd6 efd6 marked this pull request as draft September 10, 2025 01:54
@efd6 efd6 closed this in #15239 Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:snyk Snyk Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants