Skip to content

Conversation

@niraj-crest
Copy link
Contributor

@niraj-crest niraj-crest commented Jul 31, 2025

Proposed commit message

[ti_google_threat_intelligence] Resize metric panels on IOC-related dashboards (#14763) These panels previously used decimal values for width and height, but that no longer works. This change fixes the layout by using integer values. 

Earlier proposed commit message:

Remove decimal values in metric visualisation.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related Issues

Dashboard

Before (before the layout was broken)

ioc_stream_overview_dashboard ioc_stream_threat_intelligence_dashboard

After (after the layout was fixed)

ioc_stream_overview_dashboard dashboard
@niraj-crest niraj-crest requested a review from a team as a code owner July 31, 2025 13:19
@andrewkroh andrewkroh added Crest Contributions from Crest developement team. dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:ti_google_threat_intelligence Google Threat Intelligence (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 31, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@niraj-crest niraj-crest changed the title [ti_google_threat_intelligence] Resize IOC Stream Dashboard's Matrixs visualisation [ti_google_threat_intelligence] Resize IOC Stream Dashboard's Matric visualisation Aug 1, 2025
@niraj-crest niraj-crest changed the title [ti_google_threat_intelligence] Resize IOC Stream Dashboard's Matric visualisation [ti_google_threat_intelligence] Resize IOC Stream Dashboard's Metric visualisation Aug 1, 2025
Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a bit shorter vertically.

What motivated this? Just to use the space a bit more effectively or something else?

@efd6
Copy link
Contributor

efd6 commented Aug 4, 2025

/test

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@niraj-crest
Copy link
Contributor Author

Thanks! Yes, the idea was to keep all the matrices consistent by adding decimal values for width and height in the dashboard.
However, it looks like this formatting isn't supported in the newer version, so we have removed decimal values.

@niraj-crest
Copy link
Contributor Author

@chrisberkhout If every thing looks good can we please merge this PR.

@kcreddy
Copy link
Contributor

kcreddy commented Aug 7, 2025

Thanks! Yes, the idea was to keep all the matrices consistent by adding decimal values for width and height in the dashboard. However, it looks like this formatting isn't supported in the newer version, so we have removed decimal values.

@niraj-crest Can you update PR Proposed commit message to reflect this?

@niraj-crest
Copy link
Contributor Author

@kcreddy Updated proposed commit Message.

@chrisberkhout chrisberkhout added the bugfix Pull request that fixes a bug issue label Aug 7, 2025
Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the point of the change now.

I suggested a different changelog message and put a clearer proposed commit message in the description.

This was originally confusing because the before and after screenshots in the PR description looked about the same, with slight size changes (which were mostly due to different zoom). Now I get the point that the metric panels layout was broken, and this PR fixes it. I adjusted the description to show that the before screenshots are before the layout was broken.

I think this should be a bugfix rather than an enhancement.

There's one question left about what looks like extra changes.


Out of the scope of this PR: the dashboard names and descriptions are very confusing. They seem to cover a lot of the same things and in some cases use almost identical descriptions.

@chrisberkhout chrisberkhout changed the title [ti_google_threat_intelligence] Resize IOC Stream Dashboard's Metric visualisation [ti_google_threat_intelligence] Resize metric panels on IOC-related dashboards Aug 7, 2025
@niraj-crest
Copy link
Contributor Author

@chrisberkhout We have updated PR.

@chrisberkhout chrisberkhout force-pushed the ti_google_threat_intelligence-resize_ioc_stream_dashboard_matrixs branch from 015b76d to e038a8b Compare August 7, 2025 13:06
@chrisberkhout chrisberkhout enabled auto-merge (squash) August 7, 2025 13:06
@chrisberkhout
Copy link
Contributor

👍 I set it to auto-merge when the tests pass.

@niraj-crest
Copy link
Contributor Author

@chrisberkhout as all comments have been resolved so can you please Merge this PR.

@kcreddy
Copy link
Contributor

kcreddy commented Aug 8, 2025

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

@chrisberkhout chrisberkhout merged commit 81fb067 into elastic:main Aug 8, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package ti_google_threat_intelligence - 0.6.1 containing this change is available at https://epr.elastic.co/package/ti_google_threat_intelligence/0.6.1/

robester0403 pushed a commit to robester0403/integrations that referenced this pull request Aug 14, 2025
…ashboards (elastic#14763) These panels previously used decimal values for width and height, but that no longer works. This change fixes the layout by using integer values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Crest Contributions from Crest developement team. dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:ti_google_threat_intelligence Google Threat Intelligence (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

6 participants