- Notifications
You must be signed in to change notification settings - Fork 513
[ti_google_threat_intelligence] Resize metric panels on IOC-related dashboards #14763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ti_google_threat_intelligence] Resize metric panels on IOC-related dashboards #14763
Conversation
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
chrisberkhout left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a bit shorter vertically.
What motivated this? Just to use the space a bit more effectively or something else?
| /test |
🚀 Benchmarks reportTo see the full report comment with |
| Thanks! Yes, the idea was to keep all the matrices consistent by adding decimal values for width and height in the dashboard. |
| @chrisberkhout If every thing looks good can we please merge this PR. |
@niraj-crest Can you update PR |
| @kcreddy Updated proposed commit Message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the point of the change now.
I suggested a different changelog message and put a clearer proposed commit message in the description.
This was originally confusing because the before and after screenshots in the PR description looked about the same, with slight size changes (which were mostly due to different zoom). Now I get the point that the metric panels layout was broken, and this PR fixes it. I adjusted the description to show that the before screenshots are before the layout was broken.
I think this should be a bugfix rather than an enhancement.
There's one question left about what looks like extra changes.
Out of the scope of this PR: the dashboard names and descriptions are very confusing. They seem to cover a lot of the same things and in some cases use almost identical descriptions.
...nce/kibana/dashboard/ti_google_threat_intelligence-fb3daf8e-b45b-4fd9-bf94-dbaf96fcfb67.json Show resolved Hide resolved
...nce/kibana/dashboard/ti_google_threat_intelligence-55f5f53b-343e-4095-b61f-1089a5273d84.json Show resolved Hide resolved
| @chrisberkhout We have updated PR. |
015b76d to e038a8b Compare | 👍 I set it to auto-merge when the tests pass. |
| @chrisberkhout as all comments have been resolved so can you please Merge this PR. |
| /test |
💚 Build Succeeded
History
|
|
| Package ti_google_threat_intelligence - 0.6.1 containing this change is available at https://epr.elastic.co/package/ti_google_threat_intelligence/0.6.1/ |
…ashboards (elastic#14763) These panels previously used decimal values for width and height, but that no longer works. This change fixes the layout by using integer values.




Proposed commit message
Earlier proposed commit message:
Checklist
changelog.ymlfile.Related Issues
Dashboard
Before (before the layout was broken)
After (after the layout was fixed)