Skip to content

Conversation

@brijesh-elastic
Copy link
Collaborator

Proposed commit message

cisco_meraki: Harmonise `event.type` and `event.category` treatment of anyconnect_vpn_connect with client_vpn_connect events 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/cisco_meraki directory.
  • Run the following command to run tests.

elastic-package test

Related issues

@brijesh-elastic brijesh-elastic requested a review from efd6 July 30, 2025 07:09
@brijesh-elastic brijesh-elastic self-assigned this Jul 30, 2025
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner July 30, 2025 07:09
@brijesh-elastic brijesh-elastic added enhancement New feature or request Integration:cisco_meraki Cisco Meraki Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Jul 30, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

},
"event": {
"action": "anyconnect_vpn_connect",
"action": "anyconnect-vpn-connect",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice for consistency, but it would break people who are searching on "anyconnect_vpn_connect".

I think we will need to leave this the same.

@brijesh-elastic brijesh-elastic requested a review from efd6 July 30, 2025 08:28
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @brijesh-elastic

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit ee62fa7 into elastic:main Aug 4, 2025
9 checks passed
@elastic-vault-github-plugin-prod

Package cisco_meraki - 1.30.0 containing this change is available at https://epr.elastic.co/package/cisco_meraki/1.30.0/

robester0403 pushed a commit to robester0403/integrations that referenced this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cisco_meraki Cisco Meraki Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

3 participants