cisco_meraki: fix ECS mapping for translated IP and port #14389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
efd6 added Integration:cisco_meraki 
Previously these were conditionally mapped to the {source,destination}.{ip,port} fields. Instead, map them to {source,destination}.nat.{ip,port}. 
🚀 Benchmarks reportTo see the full report comment with |
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy approved these changes Jul 4, 2025
Contributor
kcreddy left a comment
kcreddy left a comment There was a problem hiding this comment.
Just a clarification. LGTM otherwise.
packages/cisco_meraki/data_stream/log/_dev/test/pipeline/test-ip-flow.log-expected.json Show resolved Hide resolved
|
💚 Build Succeeded
History
cc @efd6 |
kcreddy approved these changes Jul 4, 2025
| Package cisco_meraki - 1.29.2 containing this change is available at https://epr.elastic.co/package/cisco_meraki/1.29.2/ |
robester0403 pushed a commit to robester0403/integrations that referenced this pull request Jul 8, 2025
Previously these were conditionally mapped to the {source,destination}.{ip,port} fields. Instead, map them to {source,destination}.nat.{ip,port}. Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots