Skip to content

Conversation

@moxarth-rathod
Copy link
Contributor

@moxarth-rathod moxarth-rathod commented Jun 6, 2025

Proposed commit message

cisco_meraki: fix pipeline issue by adding a filter in grok parsing for port events. As the current Grok pattern in the ingest pipeline is designed to match log lines that indicate specific port actions, i.e. `status changes` or `STP role changes`, this PR adding a filter in grok parsing for port events to logs with actionable phrases to prevent errors from benign messages. 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install the elastic package locally.
  • Start the elastic stack using the elastic package.
  • Move to integrations/packages/cisco_meraki directory.
  • Run the following command to run tests.

elastic-package test -v

@moxarth-rathod moxarth-rathod self-assigned this Jun 6, 2025
@moxarth-rathod moxarth-rathod requested a review from a team as a code owner June 6, 2025 08:14
@moxarth-rathod moxarth-rathod added Integration:cisco_meraki Cisco Meraki bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Jun 6, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jun 6, 2025

🚀 Benchmarks report

Package cisco_meraki 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
events 250000 200000 -50000 (-20%) 💔

To see the full report comment with /test benchmark fullreport

@moxarth-rathod moxarth-rathod requested a review from ShourieG June 6, 2025 08:59
changes:
- description: Limit Grok parsing for port events to logs with actionable phrases to prevent errors from benign messages.
type: bugfix
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix pr number @moxarth-rathod

Co-authored-by: Shourie Ganguly <shourie.ganguly@elastic.co>
@moxarth-rathod moxarth-rathod requested a review from ShourieG June 10, 2025 06:56
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @moxarth-rathod

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShourieG ShourieG merged commit 0902729 into elastic:main Jun 10, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package cisco_meraki - 1.28.2 containing this change is available at https://epr.elastic.co/package/cisco_meraki/1.28.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_meraki Cisco Meraki Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

3 participants