Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented May 15, 2025

Proposed commit message

  • Use GCP OIDC to copy the logs to the private storage.
  • Use gcloud instead of gsutil (so it honours the Env variables)
  • Tear-down is now managed by the BK plugin itself.

Test

See the ci build

image

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Relates to elastic/elastic-package#2569

Screenshots


This is an automatic backport of pull request #13856 done by [Mergify](https://mergify.com).
(cherry picked from commit 47b4432)
@mergify mergify bot requested a review from a team as a code owner May 15, 2025 00:12
@mergify mergify bot mentioned this pull request May 15, 2025
5 tasks
@v1v v1v self-assigned this May 15, 2025
@v1v v1v enabled auto-merge (squash) May 15, 2025 00:47
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package fortinet_fortiedr 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 964.32 662.25 -302.07 (-31.32%) 💔

Package microsoft_dhcp 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 11764.71 8196.72 -3567.99 (-30.33%) 💔

Package modsecurity 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
auditlog 623.83 520.83 -103 (-16.51%) 💔

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@v1v v1v disabled auto-merge May 15, 2025 04:59
@v1v v1v merged commit 3d9dacd into backport-security_detection_engine-8.17 May 15, 2025
7 checks passed
@v1v v1v deleted the mergify/bp/backport-security_detection_engine-8.17/pr-13856 branch May 15, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants