[LMD] Remove time_of_day detector from ML module #13687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sodhikirti07 added enhancement 
susan-shu-c approved these changes Apr 25, 2025
|
💚 Build Succeeded
|
andrewkroh added the Team:Security-Applied ML | Pinging @elastic/sec-applied-ml (Team:Security-Applied ML) |
jmcarlock approved these changes Apr 28, 2025
| "function": "time_of_week", | ||
| "partition_field_name": "source.ip", | ||
| "detector_index": 1 | ||
| "detector_index": 0 |
Contributor
There was a problem hiding this comment.
Did you consider changing the description of the job itself, to something like Detects an RDP session started at an usual time of the week. now that it only uses the time_of_week detector?
Member
There was a problem hiding this comment.
True, @sodhikirti07 let's roll this into the next update?
| Package lmd - 2.5.0 containing this change is available at https://epr.elastic.co/package/lmd/2.5.0/ |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Remove time_of_day detector from ML module
Checklist
changelog.ymlfile.Author's Checklist
Removed
time_of_daydetector from the ML module of LMD. The ML joblmd_unusual_time_weekday_rdp_session_startoriginally used two detectors: time_of_day and time_of_week. However, since these detectors rely on different time formats, they cannot be combined in a single ML job. As a result, the time_of_day detector has been removed.How to test this PR locally
Tested locally using
elastic-packageRelated issues
Screenshots