Skip to content

Conversation

@andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jul 22, 2021

What does this PR do?

Create a new package to collect logs and metrics from Hashicorp Vault.
There are three data streams:

  • audit - Audit logs from file or TCP socket.
  • log - Operation log from file.
  • metrics - Telemetry data from the /sys/metrics API.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • Add dashboards
  • Operational logs are almost never in a file. See if we can make journald input available in Agent.
  • Add screenshots.

Reviewer Notes

  • Review field names. hashicorp_vault as a prefix to most fields is quite long.
  • Review package categories.
  • Review ECS category for audit log.

Related issues

Screenshots

hashicorp_vault-audit-dashboard

hashicorp_vault-log-dashboard

Screenshot 2021-07-27 at 12-49-25 Add integration - Hashicorp Vault - Integrations - Elastic

@elasticmachine
Copy link

elasticmachine commented Jul 22, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-12T12:35:26.233+0000

  • Duration: 15 min 7 sec

  • Commit: 7ec1880

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

Trends 🧪

Image of Build Times

Image of Tests

@andrewkroh andrewkroh marked this pull request as ready for review July 27, 2021 16:51
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh
Copy link
Member Author

run tests

Create a new package to collect logs and metrics from Hashicorp Vault. There are three data streams: - audit - Audit logs from file or TCP socket. - log - Operation log from file - metrics - Telemetry data from the /sys/metrics API. Closes #1158
@andrewkroh andrewkroh merged commit 79d8926 into elastic:master Aug 16, 2021
@andrewkroh andrewkroh added Integration:hashicorp_vault Hashicorp Vault New Integration Issue or pull request for creating a new integration package. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.15 candidate enhancement New feature or request Integration:hashicorp_vault Hashicorp Vault New Integration Issue or pull request for creating a new integration package.

4 participants