- Notifications
You must be signed in to change notification settings - Fork 513
[claroty_xdome] Initial release of Claroty xDome #13388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /test |
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
| "1000039" | ||
| ], | ||
| "source": { | ||
| "asset_id": "FZAATCV", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tinnytintin10 this integration will pull in device/entity data from Claroty. Can you confirm which fields need to be populated in order to populate the asset inventory view? Ideally, we can populate them from the get go, and avoid any rework down the line. (cc @cpascale43)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping @jamiehynds!
I see that there are vulnerability, alert, and event-related data streams, but not a dedicated asset/entity-centric data stream. @krishna-macharla can you confirm this is indeed the case?
Assuming this is correct, we need to ensure that each of the entities encountered (like hosts/devices) are properly mapped to the relevant ECS fieldsets they correspond to - such as host, user, device, etc.
For any entity that doesn't have an applicable ECS fieldset (ex., object store), you can leverage the generic entity fieldset that we're developing. You can see the details in the PR here. This generic fieldset will allow you to capture metadata for entities that don't fit into existing categories.
This ECS alignment is essential because the current architecture (which is under review) uses pivot transforms to extract and persist entity metadata from properly formatted documents. When the integration's data is correctly mapped to the relevant entity ECS fieldsets, our entity definitions will automatically identify these entities, extract their metadata, and persist them in our entity store. From there, they'll be surfaced in the inventory view.
I have asked engineering to prepare a guide. Once this guide is available, I will be sure to share it with you and the team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @nick-alayil regarding the vuln datastream. Maybe a quick win to get this integration aligned so we don't have to revisit it later?
| "family": "Autonomous Vehicle", | ||
| "value": "Autonomous Vehicle" | ||
| }, | ||
| "uid": "06f488dd-40e9-4bd9-a1d6-7c515bb1a901", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which value among the uid, id, asset_id is used by their API to query for hosts/devices?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally that field should be used to populate host.id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no id field inside the device data, hence mapping the uid with the host.id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need API doc to review this.
Whatever field Claroty xDome is using inside their hosts API (uid/id/asset_id), that field needs to be extracted into host.id. It will be useful when performing actions on hosts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...roty_xdome/data_stream/vulnerability/_dev/test/pipeline/test-vulnerability.log-expected.json Outdated Show resolved Hide resolved
...roty_xdome/data_stream/vulnerability/_dev/test/pipeline/test-vulnerability.log-expected.json Show resolved Hide resolved
1. Added saved searches in alert and vulnerability datastream. 2. Add fields into related.user 3. Mapped required vulnerability fields. 4. Added category vulnerability_management.
| /test |
...roty_xdome/data_stream/vulnerability/_dev/test/pipeline/test-vulnerability.log-expected.json Outdated Show resolved Hide resolved
...roty_xdome/data_stream/vulnerability/_dev/test/pipeline/test-vulnerability.log-expected.json Outdated Show resolved Hide resolved
...roty_xdome/data_stream/vulnerability/_dev/test/pipeline/test-vulnerability.log-expected.json Outdated Show resolved Hide resolved
1. Mapped resource.id with host.id, resource.name to host.name
| /test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please wait for @jamiehynds comment to be addressed before merging.
|
💚 Build Succeeded
History
|
Thanks @kcreddy. Confirmed with @piyush-elastic that the necessary ECS entity mappings are in place. As that fieldset evolves, there may be a need to add more mappings down the line. But for now, I'm fine with going ahead with the merge for this integration. |
| Package claroty_xdome - 0.1.0 containing this change is available at https://epr.elastic.co/package/claroty_xdome/0.1.0/ |




Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues
Screenshots