Skip to content

Conversation

@muthu-mps
Copy link
Contributor

This PR removes the zone filter and fixes the regions filter default value.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Screenshots

Screenshot 2025-01-22 at 12 40 58 PM Screenshot 2025-01-22 at 12 40 43 PM
@muthu-mps muthu-mps self-assigned this Jan 22, 2025
@muthu-mps muthu-mps added the Integration:gcp_vertexai GCP Vertex AI label Jan 22, 2025
@andrewkroh andrewkroh added the bugfix Pull request that fixes a bug issue label Jan 22, 2025
@elasticmachine
Copy link

💚 Build Succeeded

cc @muthu-mps

@muthu-mps muthu-mps marked this pull request as ready for review January 22, 2025 07:40
@muthu-mps muthu-mps requested a review from a team as a code owner January 22, 2025 07:40
@muthu-mps muthu-mps requested a review from ishleenk17 January 22, 2025 07:40
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Jan 22, 2025
@muthu-mps muthu-mps merged commit 5c42bd9 into elastic:main Jan 22, 2025
5 checks passed
@elastic-vault-github-plugin-prod

Package gcp_vertexai - 0.3.1 containing this change is available at https://epr.elastic.co/package/gcp_vertexai/0.3.1/

@shmsr
Copy link
Member

shmsr commented Jan 22, 2025

@muthu-mps But why did we remove the zone filter?

@muthu-mps
Copy link
Contributor Author

@muthu-mps But why did we remove the zone filter?

The zone filter was removed to make it similar to what we have in other cloud providers and the zone comes under the region where we decide to keep only region filter.

cc: @ishleenk17

@shmsr
Copy link
Member

shmsr commented Jan 22, 2025

Oh ok

@ishleenk17
Copy link
Member

Moreso, we are now using regions (array) for taking the region as input from user.
Having a singular zone and multiple regions doesn't make sense together.

We can have region and zone together as input configs but not regions and zone.

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@muthu-mps muthu-mps deleted the remove_zone_fix_regions branch February 7, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:gcp_vertexai GCP Vertex AI Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

5 participants