Skip to content

Commit 91619c5

Browse files
Prometheus integration: minor enhancements as an outcome of evaluation issues (#3662)
* prometheus integration: remote_write: hide some configuration settings; collector: add leader election, remove default value for ssl; query: add leader election Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add pr number Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
1 parent 2dbcf98 commit 91619c5

File tree

7 files changed

+34
-9
lines changed

7 files changed

+34
-9
lines changed

packages/prometheus/changelog.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
# newer versions go on top
2+
- version: "0.10.0"
3+
changes:
4+
- description: Hide some configuration for remote_write data_stream; Add leader election for collector and query data_streams
5+
type: enhancement
6+
link: https://github.com/elastic/integrations/pull/3662
27
- version: "0.9.2"
38
changes:
49
- description: reworded a link to related documentation in the Readme so it is clearer

packages/prometheus/data_stream/collector/agent/stream/stream.yml.hbs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,18 @@ metrics_filters.include:
1515
metrics_path: {{metrics_path}}
1616
period: {{period}}
1717
rate_counters: {{rate_counters}}
18+
{{#if ssl.certificate_authorities}}
1819
ssl.certificate_authorities:
1920
{{#each ssl.certificate_authorities}}
2021
- {{this}}
2122
{{/each}}
23+
{{/if}}
2224
use_types: {{use_types}}
2325
username: {{username}}
2426
password: {{password}}
27+
{{#if leaderelection}}
28+
condition: ${kubernetes_leaderelection.leader} == true
29+
{{/if}}
2530
{{#if query}}
2631
{{query}}
2732
{{/if}}
@@ -33,4 +38,4 @@ password: {{password}}
3338
{{/if}}
3439
{{#if timeout}}
3540
{{timeout}}
36-
{{/if}}
41+
{{/if}}

packages/prometheus/data_stream/collector/manifest.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,13 @@ streams:
4040
required: true
4141
show_user: true
4242
default: true
43+
- name: leaderelection
44+
type: bool
45+
title: Leader Election
46+
multi: false
47+
required: true
48+
show_user: false
49+
default: true
4350
- name: bearer_token_file
4451
type: text
4552
title: Bearer Token File
@@ -53,8 +60,6 @@ streams:
5360
multi: true
5461
required: false
5562
show_user: false
56-
default:
57-
- /var/run/secrets/kubernetes.io/serviceaccount/service-ca.crt
5863
- name: metrics_filters.exclude
5964
type: text
6065
title: Metrics Filters Exclude

packages/prometheus/data_stream/query/agent/stream/stream.yml.hbs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,6 @@ hosts:
55
{{/each}}
66
period: {{period}}
77
queries: {{queries}}
8+
{{#if leaderelection}}
9+
condition: ${kubernetes_leaderelection.leader} == true
10+
{{/if}}

packages/prometheus/data_stream/query/manifest.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,13 @@ streams:
4545
params:
4646
query: some_value
4747
path: /api/v1/query
48+
- name: leaderelection
49+
type: bool
50+
title: Leader Election
51+
multi: false
52+
required: true
53+
show_user: false
54+
default: true
4855
title: Prometheus query metrics
4956
enabled: false
5057
description: Collect Prometheus query metrics

packages/prometheus/data_stream/remote_write/manifest.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,21 @@ streams:
2323
title: Enabled SSL
2424
multi: false
2525
required: true
26-
show_user: true
26+
show_user: false
2727
default: false
2828
- name: ssl.certificate
2929
type: text
3030
title: SSL Certificate
3131
multi: false
3232
required: false
33-
show_user: true
33+
show_user: false
3434
default: /etc/pki/server/cert.pem
3535
- name: ssl.key
3636
type: text
3737
title: SSL Key
3838
multi: false
3939
required: false
40-
show_user: true
40+
show_user: false
4141
default: /etc/pki/server/cert.key
4242
- name: rate_counters
4343
type: bool
@@ -58,14 +58,14 @@ streams:
5858
title: Counter Type Patterns
5959
multi: true
6060
required: false
61-
show_user: true
61+
show_user: false
6262
default: []
6363
- name: types_patterns.histogram_patterns
6464
type: text
6565
title: Histogram Type Patterns
6666
multi: true
6767
required: false
68-
show_user: true
68+
show_user: false
6969
default: []
7070
title: Prometheus remote write metrics
7171
enabled: false

packages/prometheus/manifest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
format_version: 1.0.0
22
name: prometheus
33
title: Prometheus Metrics
4-
version: 0.9.2
4+
version: 0.10.0
55
license: basic
66
description: Collect metrics from Prometheus servers with Elastic Agent.
77
type: integration

0 commit comments

Comments
 (0)