Skip to content

Commit 7ead005

Browse files
authored
checkpoint,github,hid_bravura_monitor: make types match (#7714)
* checkpoint: make checkpoint.subs_exp a date * github: ensure data streams agree on type of github.repository.description * hid_bravura_monitor: make winlog.time_created a date
1 parent 1489eb9 commit 7ead005

File tree

14 files changed

+52
-10
lines changed

14 files changed

+52
-10
lines changed

packages/checkpoint/changelog.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
# newer versions go on top
2+
- version: "1.24.0"
3+
changes:
4+
- description: Ensure `checkpoint.subs_exp` is a date.
5+
type: enhancement
6+
link: https://github.com/elastic/integrations/pull/7714
27
- version: "1.23.0"
38
changes:
49
- description: Update package to ECS 8.9.0.

packages/checkpoint/data_stream/firewall/_dev/test/pipeline/test-checkpoint.log-expected.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1509,7 +1509,7 @@
15091509
"log_id": "4",
15101510
"origin_sic_name": "CN=NPFDCA00002,O=NPMDCM00001.domain.com.r44cbg",
15111511
"special_properties": "0",
1512-
"subs_exp": "Tue Jan 1 00:00:00 2030",
1512+
"subs_exp": "2030-01-01T00:00:00.000Z",
15131513
"subscription_stat": "valid",
15141514
"subscription_stat_desc": "Contract is up to date."
15151515
},

packages/checkpoint/data_stream/firewall/elasticsearch/ingest_pipeline/default.yml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -655,6 +655,33 @@ processors:
655655
} else if (iana_number == '132') {
656656
ctx.network.transport = 'sctp';
657657
}
658+
- date:
659+
field: checkpoint.subs_exp
660+
target_field: checkpoint.subs_exp
661+
timezone: "{{{ event.timezone }}}"
662+
formats:
663+
- 'EEE MMM dd HH:mm:ss yyyy'
664+
- 'EEE MMM d HH:mm:ss yyyy'
665+
- 'EEE MMM d HH:mm:ss yyyy'
666+
- ISO8601
667+
- UNIX
668+
if: "ctx.checkpoint?.subs_exp != null"
669+
on_failure:
670+
# Try to re-parse as UTC to catch when TZ is invalid or unknown.
671+
- date:
672+
tag: "date_utc_fallback"
673+
field: checkpoint.subs_exp
674+
target_field: checkpoint.subs_exp
675+
formats:
676+
- 'EEE MMM dd HH:mm:ss yyyy'
677+
- 'EEE MMM d HH:mm:ss yyyy'
678+
- 'EEE MMM d HH:mm:ss yyyy'
679+
- ISO8601
680+
- UNIX
681+
on_failure:
682+
- remove:
683+
field: checkpoint.subs_exp
684+
ignore_missing: true
658685
- convert:
659686
field: checkpoint.packets
660687
type: long

packages/checkpoint/data_stream/firewall/fields/fields.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1467,7 +1467,7 @@
14671467
description: |
14681468
Layer uid.
14691469
- name: subs_exp
1470-
type: keyword
1470+
type: date
14711471
- name: subscriber
14721472
type: ip
14731473
description: |

packages/checkpoint/docs/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ An example event for `firewall` looks as following:
518518
| checkpoint.stormagentname | | keyword |
519519
| checkpoint.sub_policy_name | Layer name. | keyword |
520520
| checkpoint.sub_policy_uid | Layer uid. | keyword |
521-
| checkpoint.subs_exp | | keyword |
521+
| checkpoint.subs_exp | | date |
522522
| checkpoint.subscriber | Source IP before CGNAT. | ip |
523523
| checkpoint.subscription_stat | | keyword |
524524
| checkpoint.subscription_stat_desc | | keyword |

packages/checkpoint/manifest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: checkpoint
22
title: Check Point
3-
version: "1.23.0"
3+
version: "1.24.0"
44
description: Collect logs from Check Point with Elastic Agent.
55
type: integration
66
format_version: 2.7.0

packages/github/changelog.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
# newer versions go on top
2+
- version: "1.20.1"
3+
changes:
4+
- description: Make datastreams agree on type of `github.repository.description`.
5+
type: bugfix
6+
link: https://github.com/elastic/integrations/pull/7714
27
- version: "1.20.0"
38
changes:
49
- description: Add support for `github.permission` and `github.repository_public` fields.

packages/github/data_stream/dependabot/fields/fields.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@
289289
290290
fields:
291291
- name: description
292-
type: keyword
292+
type: text
293293
description: >
294294
The description of the repository.
295295

packages/github/docs/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,7 @@ To use this integration, you must be an administrator for the repository or for
566566
| github.dependabot.vulnerable_manifest_filename | The vulnerable manifest filename. | keyword |
567567
| github.dependabot.vulnerable_manifest_path | The vulnerable manifest path. | keyword |
568568
| github.dependabot.vulnerable_requirements | The vulnerable requirements. | keyword |
569-
| github.repository.description | The description of the repository. | keyword |
569+
| github.repository.description | The description of the repository. | text |
570570
| github.repository.is_in_organization | Indicates if a repository is either owned by an organization, or is a private fork of an organization repository. | boolean |
571571
| github.repository.is_private | Identifies if the repository is private or internal. | boolean |
572572
| github.repository.name | Identifies if the repository is private or internal. | keyword |

packages/github/manifest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: github
22
title: GitHub
3-
version: "1.20.0"
3+
version: "1.20.1"
44
description: Collect logs from GitHub with Elastic Agent.
55
type: integration
66
format_version: 2.9.0

0 commit comments

Comments
 (0)