Skip to content

Commit 74a2c2d

Browse files
pemonttoandrewkroh
andauthored
[microsoft_dhcp] Add more event.action and event.outcome values (#2296)
Add more actions and outcomes for MS DHCP. Remove event.ingested from the pipeline because it is added by the final pipeline for Fleet. Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
1 parent ab6544b commit 74a2c2d

File tree

4 files changed

+66
-33
lines changed

4 files changed

+66
-33
lines changed

packages/microsoft_dhcp/changelog.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
# newer versions go on top
2+
- version: "1.1.0"
3+
changes:
4+
- description: Add more event.action and event.outcome values
5+
type: enhancement
6+
link: https://github.com/elastic/integrations/pull/2296
27
- version: "1.0.0"
38
changes:
49
- description: GA integration

packages/microsoft_dhcp/data_stream/log/_dev/test/pipeline/test-log.log-expected.json

Lines changed: 24 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
"version": "1.12.0"
77
},
88
"event": {
9-
"ingested": "2021-12-09T13:41:22.171223700Z",
109
"original": "01,04/19/20,13:11:13,Stopped,,,",
1110
"code": "01",
1211
"kind": "event",
@@ -31,7 +30,6 @@
3130
"version": "1.12.0"
3231
},
3332
"event": {
34-
"ingested": "2021-12-09T13:41:22.171228300Z",
3533
"original": "00,04/19/20,12:43:06,Started,,,",
3634
"code": "00",
3735
"kind": "event",
@@ -60,11 +58,11 @@
6058
"domain": "057182593757.test.com"
6159
},
6260
"event": {
63-
"ingested": "2021-12-09T13:41:22.171233100Z",
6461
"original": "30,09/20/21,09:16:15,DNS Update Request,172.28.43.169,057182593757.test.com,,,0,6,,,,,,,,,0",
6562
"code": "30",
6663
"kind": "event",
6764
"timezone": "America/New_York",
65+
"action": "dhcp-dns-update",
6866
"category": [
6967
"network"
7068
],
@@ -95,11 +93,11 @@
9593
"domain": "1-07.test.com"
9694
},
9795
"event": {
98-
"ingested": "2021-12-09T13:41:22.171238100Z",
9996
"original": "30,09/20/21,09:16:09,DNS Update Request,172.28.53.173,1-07.test.com,,,0,6,,,,,,,,,0",
10097
"code": "30",
10198
"kind": "event",
10299
"timezone": "America/New_York",
100+
"action": "dhcp-dns-update",
103101
"category": [
104102
"network"
105103
],
@@ -130,11 +128,11 @@
130128
"domain": "3-07.test.com"
131129
},
132130
"event": {
133-
"ingested": "2021-12-09T13:41:22.171242700Z",
134131
"original": "32,09/20/21,09:16:03,DNS Update Successful,172.28.53.36,3-07.test.com,,,0,6,,,,,,,,,0",
135132
"code": "32",
136133
"kind": "event",
137134
"timezone": "America/New_York",
135+
"action": "dhcp-dns-update",
138136
"category": [
139137
"network"
140138
],
@@ -165,7 +163,6 @@
165163
"ip": "172.28.52.0"
166164
},
167165
"event": {
168-
"ingested": "2021-12-09T13:41:22.171249400Z",
169166
"original": "36,09/20/21,09:18:01,Packet dropped because of Client ID hash mismatch or standby server.,172.28.52.0,,76691ED45C90,,0,6,,,,,,,,,0",
170167
"code": "36",
171168
"kind": "event",
@@ -174,9 +171,10 @@
174171
"network"
175172
],
176173
"type": [
177-
"connection"
174+
"connection",
175+
"denied"
178176
],
179-
"outcome": "success"
177+
"outcome": "failure"
180178
},
181179
"message": "Packet dropped because of Client ID hash mismatch or standby server.",
182180
"microsoft": {
@@ -200,18 +198,18 @@
200198
"domain": "035856103966.test.com"
201199
},
202200
"event": {
203-
"ingested": "2021-12-09T13:41:22.171254600Z",
204201
"original": "31,09/20/21,09:18:00,DNS Update Failed,172.28.43.159,035856103966.test.com,,,0,6,,,,,,,,,10054",
205202
"code": "31",
206203
"kind": "event",
207204
"timezone": "America/New_York",
205+
"action": "dhcp-dns-update",
208206
"category": [
209207
"network"
210208
],
211209
"type": [
212210
"connection"
213211
],
214-
"outcome": "success"
212+
"outcome": "failure"
215213
},
216214
"message": "DNS Update Failed",
217215
"microsoft": {
@@ -235,18 +233,18 @@
235233
"domain": "001100581357.test.com"
236234
},
237235
"event": {
238-
"ingested": "2021-12-09T13:41:22.171260Z",
239236
"original": "31,09/20/21,09:18:01,DNS Update Failed,172.28.40.35,001100581357.test.com,,,0,6,,,,,,,,,10054",
240237
"code": "31",
241238
"kind": "event",
242239
"timezone": "America/New_York",
240+
"action": "dhcp-dns-update",
243241
"category": [
244242
"network"
245243
],
246244
"type": [
247245
"connection"
248246
],
249-
"outcome": "success"
247+
"outcome": "failure"
250248
},
251249
"message": "DNS Update Failed",
252250
"microsoft": {
@@ -271,18 +269,19 @@
271269
"domain": "host.test.com"
272270
},
273271
"event": {
274-
"ingested": "2021-12-09T13:41:22.171266400Z",
275272
"original": "35,01/01/01,01:01:01,DNS update request failed,192.168.2.1,host.test.com,000000000000,",
276273
"code": "35",
277274
"kind": "event",
278275
"timezone": "America/New_York",
276+
"action": "dhcp-dns-update",
279277
"category": [
280278
"network"
281279
],
282280
"type": [
283-
"connection"
281+
"connection",
282+
"denied"
284283
],
285-
"outcome": "success"
284+
"outcome": "failure"
286285
},
287286
"message": "DNS update request failed",
288287
"tags": [
@@ -300,7 +299,6 @@
300299
"domain": "host.test.com"
301300
},
302301
"event": {
303-
"ingested": "2021-12-09T13:41:22.171271800Z",
304302
"original": "10,01/01/01,01:01:01,Assign,192.168.2.10,host.test.com,000000000000,,17739,0,,,",
305303
"code": "10",
306304
"kind": "event",
@@ -310,7 +308,8 @@
310308
"network"
311309
],
312310
"type": [
313-
"connection"
311+
"connection",
312+
"allowed"
314313
],
315314
"outcome": "success"
316315
},
@@ -336,7 +335,6 @@
336335
"domain": "host.test.com"
337336
},
338337
"event": {
339-
"ingested": "2021-12-09T13:41:22.171277Z",
340338
"original": "10,01/01/01,01:01:01,Assign,192.168.2.20,host.test.com,000000000000,,3096562285,0,,,,0x4D53465420352E30,MSFT 5.0,,,,0",
341339
"code": "10",
342340
"kind": "event",
@@ -346,7 +344,8 @@
346344
"network"
347345
],
348346
"type": [
349-
"connection"
347+
"connection",
348+
"allowed"
350349
],
351350
"outcome": "success"
352351
},
@@ -372,11 +371,11 @@
372371
"version": "1.12.0"
373372
},
374373
"event": {
375-
"ingested": "2021-12-09T13:41:22.171281100Z",
376374
"original": "24,11/20/20,00:00:05,Database Cleanup Begin,,,,,0,6,,,,,,,,,0",
377375
"code": "24",
378376
"kind": "event",
379377
"timezone": "America/New_York",
378+
"action": "ip-cleanup-start",
380379
"category": [
381380
"network"
382381
],
@@ -407,11 +406,11 @@
407406
"domain": "hostname.test.com"
408407
},
409408
"event": {
410-
"ingested": "2021-12-09T13:41:22.171285200Z",
411409
"original": "30,11/20/20,00:00:05,DNS Update Request,10.10.10.10,hostname.test.com,,,0,6,,,,,,,,,0",
412410
"code": "30",
413411
"kind": "event",
414412
"timezone": "America/New_York",
413+
"action": "dhcp-dns-update",
415414
"category": [
416415
"network"
417416
],
@@ -438,11 +437,11 @@
438437
"version": "1.12.0"
439438
},
440439
"event": {
441-
"ingested": "2021-12-09T13:41:22.171289600Z",
442440
"original": "17,11/20/20,00:00:05,DNS record not deleted67.43.156.15,,,,0,6,,,,,,,,,0",
443441
"code": "17",
444442
"kind": "event",
445443
"timezone": "America/New_York",
444+
"action": "dhcp-expire",
446445
"category": [
447446
"network"
448447
],
@@ -474,11 +473,11 @@
474473
"domain": "domain.local"
475474
},
476475
"event": {
477-
"ingested": "2021-12-09T13:41:22.171294600Z",
478476
"original": "55,04/19/20,12:43:54,Authorized(servicing),,domain.local,",
479477
"code": "55",
480478
"kind": "event",
481479
"timezone": "America/New_York",
480+
"action": "rogue-server-detection",
482481
"category": [
483482
"network"
484483
],
@@ -501,11 +500,11 @@
501500
"domain": "domain.local"
502501
},
503502
"event": {
504-
"ingested": "2021-12-09T13:41:22.171299500Z",
505503
"original": "60,04/19/20,12:43:21,No DC is DS Enabled,,domain.local,",
506504
"code": "60",
507505
"kind": "event",
508506
"timezone": "America/New_York",
507+
"action": "rogue-server-detection",
509508
"category": [
510509
"network",
511510
"authentication"
@@ -527,11 +526,11 @@
527526
"version": "1.12.0"
528527
},
529528
"event": {
530-
"ingested": "2021-12-09T13:41:22.171305200Z",
531529
"original": "63,04/19/20,12:43:28,Restarting rogue detection,,,",
532530
"code": "63",
533531
"kind": "event",
534532
"timezone": "America/New_York",
533+
"action": "rogue-server-detection",
535534
"category": [
536535
"network",
537536
"authentication"

packages/microsoft_dhcp/data_stream/log/elasticsearch/ingest_pipeline/default.yml

Lines changed: 36 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
## Reference document for DHCP field mapping: https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2008-R2-and-2008/dd183591(v=ws.10)
33
description: Pipeline for processing Microsoft DHCP logs.
44
processors:
5-
- set:
6-
field: event.ingested
7-
value: "{{ _ingest.timestamp }}"
85
- set:
96
field: ecs.version
107
value: "1.12.0"
@@ -82,6 +79,34 @@ processors:
8279
field: event.action
8380
value: dhcp-release
8481
if: "ctx.event?.code == '12'"
82+
- set:
83+
field: event.action
84+
value: dhcp-deny
85+
if: "ctx.event?.code == '15'"
86+
- set:
87+
field: event.action
88+
value: dhcp-delete
89+
if: "ctx.event?.code == '16'"
90+
- set:
91+
field: event.action
92+
value: dhcp-expire
93+
if: "['17', '18'].contains(ctx.event?.code)"
94+
- set:
95+
field: event.action
96+
value: ip-cleanup-start
97+
if: "ctx.event?.code == '24'"
98+
- set:
99+
field: event.action
100+
value: ip-cleanup-end
101+
if: "ctx.event?.code == '25'"
102+
- set:
103+
field: event.action
104+
value: dhcp-dns-update
105+
if: "['30', '31', '32', '34', '35'].contains(ctx.event?.code)"
106+
- set:
107+
field: event.action
108+
value: rogue-server-detection
109+
if: "ctx._tmp_?.code > 50"
85110
- append:
86111
field: event.category
87112
value: network
@@ -96,15 +121,19 @@ processors:
96121
field: event.type
97122
value: user
98123
if: "ctx._tmp_?.code >= 50 && ctx._tmp_?.code >= 60"
99-
# Related error codes according to documentation
100124
- append:
101125
field: event.type
102-
value: error
103-
if: "['50', '54', '56', '59', '64'].contains(ctx.checkpoint?.rule_action)"
126+
value: allowed
127+
if: "['10', '11', '12', '20', '21'].contains(ctx.event?.code)"
128+
- append:
129+
field: event.type
130+
value: denied
131+
if: "['14', '15', '22', '35', '36'].contains(ctx.event?.code)"
132+
# Related error codes according to documentation
104133
- set:
105134
field: event.outcome
106135
value: failure
107-
if: "['50', '54', '56', '59', '64'].contains(ctx.checkpoint?.rule_action)"
136+
if: "['02', '15', '22', '31', '33', '34', '35', '36'].contains(ctx.event?.code)"
108137
- set:
109138
field: event.outcome
110139
value: success

packages/microsoft_dhcp/manifest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
format_version: 1.0.0
22
name: microsoft_dhcp
33
title: Microsoft DHCP
4-
version: 1.0.0
4+
version: 1.1.0
55
license: basic
66
description: Collect logs from Microsoft DHCP with Elastic Agent.
77
type: integration

0 commit comments

Comments
 (0)