Skip to content

Commit 6d53434

Browse files
committed
all: remove confusing fail- prefix from error messages
This was originally added to a pipeline with a specific context of adding a machine-friendly tag to error.message, but through miscommunication was included in all subsequent extended error.message implementations.
1 parent 785e03c commit 6d53434

File tree

54 files changed

+505
-462
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+505
-462
lines changed

packages/bitwarden/changelog.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
# newer versions go on top
2+
- version: "1.0.1"
3+
changes:
4+
- description: Remove confusing error message tag prefix.
5+
type: bugfix
6+
link: https://github.com/elastic/integrations/pull/7105
27
- version: "1.0.0"
38
changes:
49
- description: Release Bitwarden as GA.

packages/bitwarden/data_stream/collection/elasticsearch/ingest_pipeline/default.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ processors:
1515
on_failure:
1616
- append:
1717
field: error.message
18-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
18+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
1919
- drop:
2020
if: ctx.json?.data != null && ctx.json.data.isEmpty()
2121
- set:

packages/bitwarden/data_stream/event/elasticsearch/ingest_pipeline/default.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ processors:
1818
on_failure:
1919
- append:
2020
field: error.message
21-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
21+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
2222
- drop:
2323
if: ctx.json?.data != null && ctx.json.data.isEmpty()
2424
- fingerprint:
@@ -47,7 +47,7 @@ processors:
4747
on_failure:
4848
- append:
4949
field: error.message
50-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
50+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
5151
- script:
5252
lang: painless
5353
ignore_failure: false
@@ -601,7 +601,7 @@ processors:
601601
on_failure:
602602
- append:
603603
field: error.message
604-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
604+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
605605
- date:
606606
field: json.date
607607
target_field: bitwarden.event.date
@@ -612,7 +612,7 @@ processors:
612612
on_failure:
613613
- append:
614614
field: error.message
615-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
615+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
616616
- convert:
617617
field: json.device
618618
tag: 'convert_device_to_string'
@@ -623,7 +623,7 @@ processors:
623623
on_failure:
624624
- append:
625625
field: error.message
626-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
626+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
627627
- script:
628628
lang: painless
629629
ignore_failure: false
@@ -671,7 +671,7 @@ processors:
671671
on_failure:
672672
- append:
673673
field: error.message
674-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
674+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
675675
- append:
676676
field: related.ip
677677
value: '{{{bitwarden.event.ip_address}}}'

packages/bitwarden/data_stream/group/elasticsearch/ingest_pipeline/default.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ processors:
1515
on_failure:
1616
- append:
1717
field: error.message
18-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
18+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
1919
- set:
2020
field: event.kind
2121
value: event
@@ -45,7 +45,7 @@ processors:
4545
on_failure:
4646
- append:
4747
field: error.message
48-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
48+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
4949
- rename:
5050
field: json.externalId
5151
target_field: bitwarden.group.external.id
@@ -78,7 +78,7 @@ processors:
7878
ignore_missing: true
7979
- append:
8080
field: error.message
81-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
81+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
8282
- foreach:
8383
field: json.collections
8484
if: ctx.json?.collections instanceof List

packages/bitwarden/data_stream/policy/elasticsearch/ingest_pipeline/default.yml

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ processors:
1515
on_failure:
1616
- append:
1717
field: error.message
18-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
18+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
1919
- drop:
2020
if: ctx.json?.data != null && ctx.json.data.isEmpty()
2121
- set:
@@ -34,7 +34,7 @@ processors:
3434
on_failure:
3535
- append:
3636
field: error.message
37-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
37+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
3838
- convert:
3939
field: json.data.autoEnrollEnabled
4040
tag: 'convert_autoEnrollEnabled_to_string'
@@ -45,7 +45,7 @@ processors:
4545
on_failure:
4646
- append:
4747
field: error.message
48-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
48+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
4949
- convert:
5050
field: json.data.capitalize
5151
tag: 'convert_capitalize_to_string'
@@ -55,7 +55,7 @@ processors:
5555
on_failure:
5656
- append:
5757
field: error.message
58-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
58+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
5959
- convert:
6060
field: json.data.disableHideEmail
6161
tag: 'convert_disableHideEmail_to_string'
@@ -66,7 +66,7 @@ processors:
6666
on_failure:
6767
- append:
6868
field: error.message
69-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
69+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
7070
- convert:
7171
field: json.data.includeNumber
7272
tag: 'convert_includeNumber_to_string'
@@ -77,7 +77,7 @@ processors:
7777
on_failure:
7878
- append:
7979
field: error.message
80-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
80+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
8181
- convert:
8282
field: json.data.minComplexity
8383
tag: 'convert_minComplexity_to_string'
@@ -88,7 +88,7 @@ processors:
8888
on_failure:
8989
- append:
9090
field: error.message
91-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
91+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
9292
- convert:
9393
field: json.data.minLength
9494
tag: 'convert_minLength_to_string'
@@ -99,7 +99,7 @@ processors:
9999
on_failure:
100100
- append:
101101
field: error.message
102-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
102+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
103103
- convert:
104104
field: json.data.minNumbers
105105
tag: 'convert_minNumbers_to_string'
@@ -110,7 +110,7 @@ processors:
110110
on_failure:
111111
- append:
112112
field: error.message
113-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
113+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
114114
- convert:
115115
field: json.data.minNumberWords
116116
tag: 'convert_minNumberWords_to_string'
@@ -121,7 +121,7 @@ processors:
121121
on_failure:
122122
- append:
123123
field: error.message
124-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
124+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
125125
- convert:
126126
field: json.data.minSpecial
127127
tag: 'convert_minSpecial_to_string'
@@ -132,7 +132,7 @@ processors:
132132
on_failure:
133133
- append:
134134
field: error.message
135-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
135+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
136136
- convert:
137137
field: json.data.minutes
138138
tag: 'convert_minutes_to_string'
@@ -142,7 +142,7 @@ processors:
142142
on_failure:
143143
- append:
144144
field: error.message
145-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
145+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
146146
- convert:
147147
field: json.data.requireLower
148148
tag: 'convert_requireLower_to_string'
@@ -153,7 +153,7 @@ processors:
153153
on_failure:
154154
- append:
155155
field: error.message
156-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
156+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
157157
- convert:
158158
field: json.data.requireNumbers
159159
tag: 'convert_requireNumbers_to_string'
@@ -164,7 +164,7 @@ processors:
164164
on_failure:
165165
- append:
166166
field: error.message
167-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
167+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
168168
- convert:
169169
field: json.data.requireSpecial
170170
tag: 'convert_requireSpecial_to_string'
@@ -175,7 +175,7 @@ processors:
175175
on_failure:
176176
- append:
177177
field: error.message
178-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
178+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
179179
- convert:
180180
field: json.data.requireUpper
181181
tag: 'convert_requireUpper_to_string'
@@ -186,7 +186,7 @@ processors:
186186
on_failure:
187187
- append:
188188
field: error.message
189-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
189+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
190190
- convert:
191191
field: json.data.useLower
192192
tag: 'convert_useLower_to_string'
@@ -197,7 +197,7 @@ processors:
197197
on_failure:
198198
- append:
199199
field: error.message
200-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
200+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
201201
- convert:
202202
field: json.data.useNumbers
203203
tag: 'convert_useNumbers_to_string'
@@ -208,7 +208,7 @@ processors:
208208
on_failure:
209209
- append:
210210
field: error.message
211-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
211+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
212212
- convert:
213213
field: json.data.useSpecial
214214
tag: 'convert_useSpecial_to_string'
@@ -219,7 +219,7 @@ processors:
219219
on_failure:
220220
- append:
221221
field: error.message
222-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
222+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
223223
- convert:
224224
field: json.data.useUpper
225225
tag: 'convert_useUpper_to_string'
@@ -230,7 +230,7 @@ processors:
230230
on_failure:
231231
- append:
232232
field: error.message
233-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
233+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
234234
- rename:
235235
field: json.data.defaultType
236236
target_field: json.data.default_type
@@ -257,7 +257,7 @@ processors:
257257
on_failure:
258258
- append:
259259
field: error.message
260-
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
260+
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
261261
- script:
262262
lang: painless
263263
ignore_failure: false

packages/bitwarden/manifest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
format_version: 2.7.0
22
name: bitwarden
33
title: Bitwarden
4-
version: "1.0.0"
4+
version: "1.0.1"
55
source:
66
license: Elastic-2.0
77
description: Collect logs from Bitwarden with Elastic Agent.

packages/cisco_nexus/changelog.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
# newer versions go on top
2+
- version: "0.14.2"
3+
changes:
4+
- description: Remove confusing error message tag prefix.
5+
type: bugfix
6+
link: https://github.com/elastic/integrations/pull/7105
27
- version: "0.14.1"
38
changes:
49
- description: Add support for new log format.

0 commit comments

Comments
 (0)