Fix sub_searches serialization bug #97587
Conversation
jdconrad added >bug :Search Relevance/Ranking 
| Hi @jdconrad, I've created a changelog YAML for you. |
| Pinging @elastic/es-search (Team:Search) |
| if (out.getTransportVersion().onOrAfter(TransportVersion.V_8_500_013)) { | ||
| out.writeList(subSearchSourceBuilders); | ||
| } else if (out.getTransportVersion().before(TransportVersion.V_8_8_0) && subSearchSourceBuilders.size() >= 2) { | ||
| } else if (out.getTransportVersion().before(TransportVersion.V_8_4_0) && subSearchSourceBuilders.size() >= 2) { |
There was a problem hiding this comment.
this only works if one of the subsearches is kNN and one is a query. Two queries breaks here right?
There was a problem hiding this comment.
That is correct. However, I don't like the fragility of doing an instanceof check to ensure that one of these is a kNN query. Versions prior to the implementation kNN should break anyway when de-serializing the knn docs and score query. At this point I would prefer to rely on the implicit contract with the user of not using new features during upgrades that are unsupported. For any case after or equal to 8.4 it would send a combined boolean query to the old node which is the same as what happens in the newer versions. Also if ranking is involved serialization will fail as part of the ShardSearchRequest.
| @elasticsearchmachine run elasticsearch-ci/bwc |
| @elasticmachine update branch |
| @elasticmachine elasticsearch-ci/full-bwc |
| @elasticmachine run elasticsearch-ci/full-bwc |
| @benwtrent Thanks for the review and adding full-bwc! |
We have allowed hybrid search since 8.4. This means the internal changes for sub_searches must be able to write a compound query as early as 8.4, but currently we only do that back to 8.8. This change fixes that issue. Closes #elastic#97144
💚 Backport successful
|
We have allowed hybrid search since 8.4. This means the internal changes for sub_searches must be able to write a compound query as early as 8.4, but currently we only do that back to 8.8. This change fixes that issue. Closes ##97144
5 participants
We have allowed hybrid search since 8.4. This means the internal changes for
sub_searchesmust be able to write a compound query as early as 8.4, but currently we only do that back to 8.8. This change fixes that issue.Closes ##97144