Made _mvt REST handler public in serverless #97405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
craigtaverner added >enhancement :Analytics/Geo 
Collaborator
| Pinging @elastic/es-analytics-geo (Team:Analytics) |
Collaborator
| Hi @craigtaverner, I've created a changelog YAML for you. |
Contributor
| I would prefer to nark this as a non-issue (contrary to your observation, the ones I saw are marked as non-issue). Otherwise LGTM . I wait for @martijnvg for reviewing it. |
martijnvg approved these changes Jul 6, 2023
docs/changelog/97405.yaml Outdated
| @@ -0,0 +1,5 @@ | |||
| pr: 97405 | |||
Member
There was a problem hiding this comment.
When labelling this as a non issue, this changelog can be removed.
Contributor Author
There was a problem hiding this comment.
When I changed the label, the changelog was removed, and a rebuild did not happen - cool!
Contributor Author
There was a problem hiding this comment.
Spoke too soon. Rebuild running. I'll wait for that to finish before merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Apparently all REST API's need an explicit @ServerlessScope annotation in order to be public in serverless contexts. I labeled this
enhancementbecause I found similar PRs for other search API's what added this annotation as an enhancement.