Skip to content

Conversation

@martijnvg
Copy link
Member

Take index mode into account during parsing of the mapping when determining whether source is synthetic

Fixes #97320

@martijnvg martijnvg added :Search Foundations/Mapping Index mappings, including merging and defining field types :StorageEngine/TSDB You know, for Metrics v8.10.0 v8.9.1 >bug labels Jul 4, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @martijnvg, I've created a changelog YAML for you.

@martijnvg martijnvg force-pushed the mapper_parser_synthetic_source branch from 1500d3c to 27b2721 Compare July 5, 2023 12:36
Take index mode into account during parsing of the mapping when determining whether source is synthetic Fixes elastic#97320
@martijnvg martijnvg force-pushed the mapper_parser_synthetic_source branch from 27b2721 to ad0afb4 Compare July 5, 2023 13:08
@martijnvg martijnvg marked this pull request as ready for review July 5, 2023 13:17
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jul 5, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @martijnvg, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martijnvg
Copy link
Member Author

Thanks for reviewing Alan!

@martijnvg
Copy link
Member Author

@elasticmachine update branch

@martijnvg martijnvg added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged labels Jul 6, 2023
@elasticsearchmachine elasticsearchmachine merged commit 5556158 into elastic:main Jul 6, 2023
@martijnvg martijnvg deleted the mapper_parser_synthetic_source branch July 6, 2023 10:42
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Jul 6, 2023
…lastic#97355) Take index mode into account during parsing of the mapping when determining whether source is synthetic Fixes elastic#97320
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.9
elasticsearchmachine pushed a commit that referenced this pull request Jul 6, 2023
…ve. (#97355) (#97418) * Fix mapping parsing logic to determine synthetic source is active. (#97355) Take index mode into account during parsing of the mapping when determining whether source is synthetic Fixes #97320 * update skip version
@rjernst rjernst removed the v8.9.1 label Jul 21, 2023
@rjernst rjernst added the v8.9.0 label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Search Foundations/Mapping Index mappings, including merging and defining field types :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Meta label for search team v8.9.0 v8.10.0

5 participants