Avoid getStateForMasterService where possible #97304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`Coordinator#getStateForMasterService` will rebuild the state to add a no-master block, which can be rather expensive if there are lots of index blocks to process too. This commit replaces most of its usages with something cheaper. Relates elastic#97295
DaveCTurner added >bug :Distributed Coordination/Cluster Coordination 
elasticsearchmachine added the Team:Distributed (Obsolete) 
| Pinging @elastic/es-distributed (Team:Distributed) |
| Hi @DaveCTurner, I've created a changelog YAML for you. |
original-brownbear approved these changes Jul 3, 2023
DaveCTurner added auto-merge-without-approval DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jul 9, 2023
`Coordinator#getStateForMasterService` will rebuild the state to add a no-master block, which can be rather expensive if there are lots of index blocks to process too. This commit replaces most of its usages with something cheaper. Relates elastic#97295
💚 Backport successful
|
elasticsearchmachine pushed a commit that referenced this pull request Jul 9, 2023
`Coordinator#getStateForMasterService` will rebuild the state to add a no-master block, which can be rather expensive if there are lots of index blocks to process too. This commit replaces most of its usages with something cheaper. Relates #97295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Coordinator#getStateForMasterServicewill rebuild the state to add ano-master block, which can be rather expensive if there are lots of
index blocks to process too. This commit replaces most of its usages
with something cheaper.
Relates #97295