Skip SortingDigest when merging a large digest in HybridDigest #97099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is a small performance optimization that avoids creating an intermediate SortingDigest when merging a digest tracking many samples. The current behavior is to keep adding values to SortingDigest until we cross the threshold for switching to MergingDigest, at which point we copy all values from SortingDigest to MergingDigest and release the former. As a side cleanup, remove the methods for adding a list of digests. It's not used anywhere and it can be tricky to get right - the current implementation for HybridDigest is buggy.
kkrik-es added >enhancement :Analytics/Aggregations 
| Hi @kkrik-es, I've created a changelog YAML for you. |
| Pinging @elastic/es-analytics-geo (Team:Analytics) |
martijnvg approved these changes Jun 26, 2023
Agreed. |
kkrik-es added v8.9.0 auto-backport-and-merge v8.9.1 auto-backport kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Jun 26, 2023
…lastic#97099) * Skip SortingDigest when merging a large digest in HybridDigest. This is a small performance optimization that avoids creating an intermediate SortingDigest when merging a digest tracking many samples. The current behavior is to keep adding values to SortingDigest until we cross the threshold for switching to MergingDigest, at which point we copy all values from SortingDigest to MergingDigest and release the former. As a side cleanup, remove the methods for adding a list of digests. It's not used anywhere and it can be tricky to get right - the current implementation for HybridDigest is buggy. * Update docs/changelog/97099.yaml
💚 Backport successful
|
kkrik-es added a commit that referenced this pull request Jun 26, 2023
…97099) (#97106) * Skip SortingDigest when merging a large digest in HybridDigest. This is a small performance optimization that avoids creating an intermediate SortingDigest when merging a digest tracking many samples. The current behavior is to keep adding values to SortingDigest until we cross the threshold for switching to MergingDigest, at which point we copy all values from SortingDigest to MergingDigest and release the former. As a side cleanup, remove the methods for adding a list of digests. It's not used anywhere and it can be tricky to get right - the current implementation for HybridDigest is buggy. * Update docs/changelog/97099.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a small performance optimization that avoids creating an intermediate
SortingDigestwhen merging a digest with many samples. The current behavior is to keep adding values toSortingDigestuntil we cross the threshold for switching toMergingDigest, at which point we copy all values fromSortingDigesttoMergingDigestand release the former.As a side cleanup, remove the methods for merging a list of digests. They are not used anywhere and can be tricky to get right - the current implementation for HybridDigest is buggy.