Fix Painless method lookup over unknown super interfaces #97062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In Java 21 List now extends SequencedCollection, instead of Collection directly. When resolving methods Painless starts at the defined type, and iterates up through super classes and interfaces. Unfortunately if a superinterface was not known, as it is for SequencedCollection since it is not in the allowed list of classes, method resolution would give up. This commit adjusts the superinterface interation to continue traversing until the method is found or no more superinterfaces are found. fixes elastic#97022
rjernst added >bug :Core/Infra/Scripting 
| Pinging @elastic/es-core-infra (Team:Core/Infra) |
| Hi @rjernst, I've created a changelog YAML for you. |
rjernst added auto-merge-without-approval rjernst added a commit to rjernst/elasticsearch that referenced this pull request Jun 24, 2023
In Java 21 List now extends SequencedCollection, instead of Collection directly. When resolving methods Painless starts at the defined type, and iterates up through super classes and interfaces. Unfortunately if a superinterface was not known, as it is for SequencedCollection since it is not in the allowed list of classes, method resolution would give up. This commit adjusts the superinterface interation to continue traversing until the method is found or no more superinterfaces are found. fixes elastic#97022
💚 Backport successful
|
elasticsearchmachine pushed a commit that referenced this pull request Jun 24, 2023
…7064) In Java 21 List now extends SequencedCollection, instead of Collection directly. When resolving methods Painless starts at the defined type, and iterates up through super classes and interfaces. Unfortunately if a superinterface was not known, as it is for SequencedCollection since it is not in the allowed list of classes, method resolution would give up. This commit adjusts the superinterface interation to continue traversing until the method is found or no more superinterfaces are found. fixes #97022
breskeby pushed a commit to breskeby/elasticsearch that referenced this pull request Sep 5, 2023
In Java 21 List now extends SequencedCollection, instead of Collection directly. When resolving methods Painless starts at the defined type, and iterates up through super classes and interfaces. Unfortunately if a superinterface was not known, as it is for SequencedCollection since it is not in the allowed list of classes, method resolution would give up. This commit adjusts the superinterface interation to continue traversing until the method is found or no more superinterfaces are found. fixes elastic#97022 (cherry picked from commit 16b4557) # Conflicts: # gradle.properties
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
breskeby added a commit that referenced this pull request Sep 5, 2023
…9196) In Java 21 List now extends SequencedCollection, instead of Collection directly. When resolving methods Painless starts at the defined type, and iterates up through super classes and interfaces. Unfortunately if a superinterface was not known, as it is for SequencedCollection since it is not in the allowed list of classes, method resolution would give up. This commit adjusts the superinterface interation to continue traversing until the method is found or no more superinterfaces are found. fixes #97022 (cherry picked from commit 16b4557) # Conflicts: # gradle.properties Co-authored-by: Ryan Ernst <ryan@iernst.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In Java 21 List now extends SequencedCollection, instead of Collection directly. When resolving methods Painless starts at the defined type, and iterates up through super classes and interfaces. Unfortunately if a superinterface was not known, as it is for SequencedCollection since it is not in the allowed list of classes, method resolution would give up. This commit adjusts the superinterface interation to continue traversing until the method is found or no more superinterfaces are found.
fixes #97022