Skip to content

Conversation

@ywangd
Copy link
Member

@ywangd ywangd commented Jun 21, 2023

This PR makes sure checkApplicationResourcePrivileges works when any of the baseRole and limitedByRole is itself a LimitedRole.

Relates: #95170, #93306

This PR makes sure checkApplicationResourcePrivileges works when any of the baseRole and limitedByRole is itself a LimitedRole. Relates: elastic#95170, elastic#93306
@ywangd ywangd added >enhancement :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC v8.9.0 labels Jun 21, 2023
@ywangd ywangd requested a review from n1v0lg June 21, 2023 07:24
@elasticsearchmachine elasticsearchmachine added v8.10.0 Team:Security Meta label for security team labels Jun 21, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @ywangd, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd
Copy link
Member Author

ywangd commented Jun 21, 2023

@elasticmachine update branch

@ywangd
Copy link
Member Author

ywangd commented Jun 21, 2023

@elasticmachine run elasticsearch-ci/part-3-fips

@ywangd ywangd added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 21, 2023
@elasticsearchmachine elasticsearchmachine merged commit 5428c4b into elastic:main Jun 21, 2023
@ywangd ywangd deleted the limited-role-check-application-privileges branch June 21, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >enhancement :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team v8.9.0 v8.10.0

4 participants