Skip to content

Conversation

@iverase
Copy link
Contributor

@iverase iverase commented Jun 15, 2023

Currently we always resolve the tiler using recursion which is not optimal when a geometry only touches a few hashes. This PR adds the logic to use brute force approach when it is appropriate very much the shame way we do it in GeoTileGridTiler.

Quick check shows that an aggregation that was timing out (>30s) now takes 4 seconds.

@iverase iverase added >enhancement :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.9.0 labels Jun 15, 2023
@iverase iverase requested a review from craigtaverner June 15, 2023 10:51
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 15, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @iverase, I've created a changelog YAML for you.

Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement. The algorithm was a little tricky to follow with the x-increment happening in-line in the loop, but the y-increment hidden inside moveDown which doubled as an initializer. But I got it in the end.

@iverase iverase merged commit 51cc89d into elastic:main Jun 15, 2023
@iverase iverase deleted the geohasgrid branch June 15, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.9.0

3 participants