Become candidate on publication failure #96490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
If the publication fails before starting (e.g. due to one of the precondition checks in `CoordinationState#handleClientValue`) then we must explicitly stand down as leader. Closes elastic#96273
DaveCTurner added >bug :Distributed Coordination/Cluster Coordination 
| Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine added the Team:Distributed (Obsolete) | Hi @DaveCTurner, I've created a changelog YAML for you. |
| I'm a little surprised not to have seen this before, but I suspect that if there's multiple master nodes involved then we're forced into a higher term anyway, so this only happens in the atomic register setup. |
DaveCTurner deleted the 2023-06-01-become-candidate-on-publication-failure branch This was referenced Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If the publication fails before starting (e.g. due to one of the precondition checks in
CoordinationState#handleClientValue) then we must explicitly stand down as leader.Closes #96273