Upgrade Lucene to a 9.7.0 snapshot #96433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
javanna added :Search/Search 
| Documentation preview: |
| Pinging @elastic/es-search (Team:Search) |
| Hi @javanna, I've created a changelog YAML for you. |
...-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java Outdated Show resolved Hide resolved
| @elasticmachine run elasticsearch-ci/part-1 |
| @elasticmachine run elasticsearch-ci/part-1 |
| @elasticmachine run elasticsearch-ci/docs-check |
…tor.vector" in the output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Most relevant changes:
As part of this PR I moved the ES codebase off of overriding or relying on the deprecated
rewrite(IndexReader)method in favour of usingrewrite(IndexSearcher)instead. For score functions, I went for not breaking existing plugins and create a new IndexSearcher whenever we rewrite a filter, otherwise we'd need to change theScoreFunction#rewritesignature to take a searcher instead of a reader.