Promptly fail recovery from snapshot #96421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Recovering a blob from snapshot may take some time. If the recovery is cancelled during this time, there is no point in continuing, and indeed we must give up as soon as possible to avoid holding the shard lock for longer than necessary. This commit checks for cancellation on every read from the blob store, rather than just between blobs. Closes elastic#95525
DaveCTurner added >bug :Distributed Indexing/Recovery 
elasticsearchmachine added the Team:Distributed (Obsolete) 
| Pinging @elastic/es-distributed (Team:Distributed) |
| Hi @DaveCTurner, I've created a changelog YAML for you. |
fcofdez approved these changes May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Recovering a blob from snapshot may take some time. If the recovery is cancelled during this time, there is no point in continuing, and indeed we must give up as soon as possible to avoid holding the shard lock for longer than necessary. This commit checks for cancellation on every read from the blob store, rather than just between blobs.
Closes #95525