Allow unsigned long field to use decay functions #96394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jdconrad added >enhancement :Search Foundations/Mapping 
| Pinging @elastic/es-search (Team:Search) |
| Hi @jdconrad, I've created a changelog YAML for you. |
| | ||
| @Override | ||
| public double evaluate(double value, double scale) { | ||
| // throw new IllegalArgumentException("HELLO: [" + value + "] [" + scale + "]"); |
There was a problem hiding this comment.
Should we remove this line ;) ?
There was a problem hiding this comment.
Haha, yes! Thanks for catching this 🤦 .
mayya-sharipova approved these changes May 30, 2023
There was a problem hiding this comment.
Thanks @jdconrad, LGTM, except we need to remove a comment line.
| @mayya-sharipova Thank you for the review. I will commit as soon as CI passes. |
| Hi @jdconrad, I've updated the changelog YAML for you. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change adds support for unsigned long fields (and any fields that can provide numeric data) to use decay functions as described by (#89603). This allows mapped fields developed as plugins to also have access to this set of functions provided they return
IndexNumericFieldDatafromgetForField.Closes #89603.