Chunk profiling stacktrace response #96340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
With this commit we implement chunking for the get stacktraces API in the profiling plugin as typical response sizes are dozens of MB large.
danielmitterdorfer added >enhancement v8.9.0 :UniversalProfiling/Application 
| Pinging @elastic/profiling (Team:Universal Profiling) |
| Hi @danielmitterdorfer, I've created a changelog YAML for you. |
| @original-brownbear I've assigned you as a reviewer as you've implemented the underlying infrastructure and I'd appreciate if you could take a look. One remark about the test case: I did not inherit from |
DaveCTurner reviewed May 25, 2023
x-pack/plugin/profiler/src/main/java/org/elasticsearch/xpack/profiler/GetProfilingResponse.java Show resolved Hide resolved
original-brownbear approved these changes May 25, 2023
DaveCTurner approved these changes May 25, 2023
| Thanks both for the quick review! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With this commit we implement chunking for the get stacktraces API in the profiling plugin as typical response sizes are dozens of MB large.