- Notifications
You must be signed in to change notification settings - Fork 25.6k
Add ingest information to the cluster info endpoint #96328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Documentation preview: |
| Pinging @elastic/es-data-management (Team:Data Management) |
| Hi @HiDAl, I've created a changelog YAML for you. |
| ======= | ||
| `count`:: | ||
| (integer) | ||
| Total number of documents ingested during the lifetime of the cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the lifetime of the cluster? Or the lifetimes of all the nodes that are currently in the cluster (i.e. a node loses these counts on restart right?)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right... Will see how to reword this... Anyway, this is going to be a really weird number, because it won't be all the time increasing with nodes restarting...
@dakrone This is an important point to consider for these statistics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this is tricky. Each node tracks the information it has seen since it started. This cluster-wide info view is the sum of those since-the-node-started statistics for all the nodes.
It's straightforward enough to talk about on this PR, but I'm not sure what I think would be appropriate wording for documentation. 😬
…est will be executed at first :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me. Tagging @joegallo in case he's currently working on something that would impact this.
| GET /_info/ingest | ||
| # returns the http and ingest info of the cluster | ||
| GET /_info/ingest,ingest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant GET /_info/http,ingest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
rename pipeline & index to avoid collisions with other tests
| Hi @HiDAl, I've updated the changelog YAML for you. |
| - is_true: ingest.total | ||
| - gte: { ingest.total.count: 2 } | ||
| - gte: { ingest.total.time_in_millis: 0 } | ||
| # next 2 conditions _should_ be 0, but because these yaml tests are sharing the same test cluster, other tests could |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, but the issue in this comment applies to all these gtes, not just the two below. Maybe reword and relocate?
| Not a review, just a comment, but this new capability puts a song in my heart. 😄 |
| @elasticsearchmachine run elasticsearch-ci/docs |
Add a new target (
ingest) to the/_infoAPI. It consolidates all theingestinformation from the cluster nodes and returns a summary at the cluster level (compared with_nodes/stats/ingestit lacks the<node>dimension)closes #95392