Skip to content

Fix retry_on_conflict parameter in update API to not retry indefinitely #96262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2023
Merged

Fix retry_on_conflict parameter in update API to not retry indefinitely #96262

merged 5 commits into from
Jun 12, 2023

Conversation

@felixbarny
Copy link
Member

Previously, any value greater than 0 for the retry_on_conflict parameter would retry indefinitely as the retry counter was never incremented.
@felixbarny felixbarny added >bug :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. labels May 22, 2023
@elasticsearchmachine elasticsearchmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.9.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels May 22, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)
@elasticsearchmachine
Copy link
Collaborator

Hi @felixbarny, I've created a changelog YAML for you.
@felixbarny felixbarny mentioned this pull request May 22, 2023
Merged
4 tasks
henningandersen
henningandersen requested changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this. I think we need to change the implementation slightly and add a bit more testing, see inline comments.
@henningandersen henningandersen self-requested a review June 12, 2023 07:48
henningandersen
henningandersen approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@felixbarny felixbarny merged commit 22d2709 into elastic:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.9.0

3 participants

@felixbarny @elasticsearchmachine @henningandersen