Don't generate stacktrace in EarlyTerminationException and TimeExceededException #95910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
iverase added >enhancement :Search/Search 
| Pinging @elastic/es-search (Team:Search) |
| Hi @iverase, I've created a changelog YAML for you. |
javanna approved these changes May 8, 2023
server/src/main/java/org/elasticsearch/search/query/QueryPhase.java Outdated Show resolved Hide resolved
javanna reviewed May 8, 2023
server/src/main/java/org/elasticsearch/search/query/EarlyTerminatingCollector.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Those exceptions are only created to terminate a search task and never expose to the user so there is no point to generate the stacktrace.
Inspired by apache/lucene#12270