Avoid stack overflow while parsing mapping #95705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mayya-sharipova added >bug :Search Foundations/Mapping 
| Pinging @elastic/es-search (Team:Search) |
| Hi @mayya-sharipova, I've created a changelog YAML for you. |
Parsing a hugely nested mapping can lead to stack overflow errors. This PR introduces a protection against this by tracking the depth level while parsing a object in the mapping, and throwing an error if the max depth level is exceeded. Currently we do have a protection against super deep object introduced in elastic#90285. But this protection is happening during dynamic mapping update, when the mapping is already parsed. To avoid stack overflow during parsing, we need this change as well. Closes elastic#52098
mayya-sharipova force-pushed the stack-overflow-mapping branch from c16c5d9 to 91774bd Compare | Hi @mayya-sharipova, I've created a changelog YAML for you. |
romseygeek reviewed May 2, 2023
server/src/main/java/org/elasticsearch/index/mapper/ObjectMapper.java Outdated Show resolved Hide resolved
mayya-sharipova force-pushed the stack-overflow-mapping branch from f38127d to 7bf075f Compare romseygeek reviewed May 18, 2023
server/src/test/java/org/elasticsearch/index/mapper/MappingParserTests.java Show resolved Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/MapperService.java Outdated Show resolved Hide resolved
| @romseygeek Thanks for the review so far, do you have further comments for this PR? |
romseygeek approved these changes May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Parsing a hugely nested mapping can lead to stack overflow errors.
This PR introduces a protection against this by tracking the depth level
while parsing a object in the mapping, and throwing an error if the max depth
level is exceeded.
Currently we do have a protection against super deep object introduced
in #90285. But this protection is happening during dynamic mapping
update, when the mapping is already parsed. To avoid stack overflow
during parsing, we need this change as well.
Closes #52098