Test downsampling of empty and missing labels #95568
Conversation
salvatore-campagna added :StorageEngine/Rollup 
| Pinging @elastic/es-analytics-geo (Team:Analytics) |
martijnvg left a comment
martijnvg left a comment There was a problem hiding this comment.
One comment, otherwise LGTM.
| --- | ||
| "Downsample empty and missing labels": | ||
| - skip: | ||
| version: " - 8.4.99" |
There was a problem hiding this comment.
I always try to put there the minimum possible value which is 8.4.99 because in 8.5.0 we changed something around naming which also includes renaming endpoints. My understanding is that this (using the minimum possible versions) allows us to run those tests also in mixed cluster tests where there are nodes running older version of ES. Am I wrong?
This should indeed work also for versions 8.5, 8.6 and 8.7.
There was a problem hiding this comment.
If from 8.5.0 there are no breaking changes then this skip version makes sense.
There is another aspect and that prior to 8.7.0, downsampling was tech preview.
With that in mind, I think actually many of our tsdb yaml tests can skip versions older than that version.
But maybe we can chat about this next week.
Use the Downsampling GA version as the minimum required.
| @elasticsearchmachine test this please |
4 participants
Here we test the bahaviour of downsampling with missing or null labels.
The test shows that we always keep the most recent non-null non-missing
value for a specific fixed interval.